mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-07-18 21:14:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Separate multiple values in basic tag with " / " instead of " "

Browse Source
This commit is contained in:
Urs Fleisch
2023-11-24 17:46:53 +01:00
parent c1bb678695
commit 9df243ef74
22 changed files with 115 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/test_apetag.cpp
View File

@ -80,7 +80,7 @@ public:
tag.setProperties(dict);
CPPUNIT_ASSERT_EQUAL(String("17"), tag.itemListMap()["TRACK"].values()[0]);
CPPUNIT_ASSERT_EQUAL(2u, tag.itemListMap()["ARTIST"].values().size());
CPPUNIT_ASSERT_EQUAL(String("artist 1 artist 2"), tag.artist());
CPPUNIT_ASSERT_EQUAL(String("artist 1 / artist 2"), tag.artist());
CPPUNIT_ASSERT_EQUAL(17u, tag.track());
const APE::Item &textItem = tag.itemListMap()["TRACK"];
CPPUNIT_ASSERT_EQUAL(APE::Item::Text, textItem.type());

6
tests/test_id3v2.cpp
View File

@ -957,7 +957,7 @@ public:
ID3v2::Tag tag;
tag.addFrame(frame);
CPPUNIT_ASSERT_EQUAL(String("Disco Eurodisco"), tag.genre());
CPPUNIT_ASSERT_EQUAL(String("Disco / Eurodisco"), tag.genre());
}
void testUpdateGenre23_3()
@ -980,7 +980,7 @@ public:
ID3v2::Tag tag;
tag.addFrame(frame);
CPPUNIT_ASSERT_EQUAL(String("Metal Black Metal Viking Metal"), tag.genre());
CPPUNIT_ASSERT_EQUAL(String("Metal / Black Metal / Viking Metal"), tag.genre());
}
void testUpdateGenre24()
@ -1000,7 +1000,7 @@ public:
ID3v2::Tag tag;
tag.addFrame(frame);
CPPUNIT_ASSERT_EQUAL(String("R&B Eurodisco"), tag.genre());
CPPUNIT_ASSERT_EQUAL(String("R&B / Eurodisco"), tag.genre());
}
void testUpdateDate22()

2
tests/test_tag_c.cpp
View File

@ -181,7 +181,7 @@ public:
TagLib_Tag *tag = taglib_file_tag(file);
CPPUNIT_ASSERT_EQUAL("Quod Libet Test Data"s, std::string(taglib_tag_album(tag)));
CPPUNIT_ASSERT_EQUAL("piman jzig"s, std::string(taglib_tag_artist(tag)));
CPPUNIT_ASSERT_EQUAL("piman / jzig"s, std::string(taglib_tag_artist(tag)));
CPPUNIT_ASSERT_EQUAL("Silence"s, std::string(taglib_tag_genre(tag)));
CPPUNIT_ASSERT_EQUAL(""s, std::string(taglib_tag_comment(tag)));
CPPUNIT_ASSERT_EQUAL("Silence"s, std::string(taglib_tag_title(tag)));

10
tests/test_xiphcomment.cpp
View File

@ -144,15 +144,15 @@ public:
f.tag()->addField("TITLE", "Title3", false);
f.tag()->addField("artist", "Artist1");
f.tag()->addField("ARTIST", "Artist2", false);
CPPUNIT_ASSERT_EQUAL(String("Title1 Title1 Title2 Title3"), f.tag()->title());
CPPUNIT_ASSERT_EQUAL(String("Artist1 Artist2"), f.tag()->artist());
CPPUNIT_ASSERT_EQUAL(String("Title1 / Title1 / Title2 / Title3"), f.tag()->title());
CPPUNIT_ASSERT_EQUAL(String("Artist1 / Artist2"), f.tag()->artist());
f.tag()->removeFields("title", "Title1");
CPPUNIT_ASSERT_EQUAL(String("Title2 Title3"), f.tag()->title());
CPPUNIT_ASSERT_EQUAL(String("Artist1 Artist2"), f.tag()->artist());
CPPUNIT_ASSERT_EQUAL(String("Title2 / Title3"), f.tag()->title());
CPPUNIT_ASSERT_EQUAL(String("Artist1 / Artist2"), f.tag()->artist());
f.tag()->removeFields("Artist");
CPPUNIT_ASSERT_EQUAL(String("Title2 Title3"), f.tag()->title());
CPPUNIT_ASSERT_EQUAL(String("Title2 / Title3"), f.tag()->title());
CPPUNIT_ASSERT(f.tag()->artist().isEmpty());
f.tag()->removeAllFields();