mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2026-04-03 12:42:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy: avoid C casting

Browse Source 
Found with google-readability-casting

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev
2022-11-26 22:02:47 -08:00
committed by Urs Fleisch
parent 4dc6bdcd28
commit 983a35f5ae
27 changed files with 64 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
taglib/ogg/oggpage.cpp
View File

@ -103,10 +103,10 @@ Ogg::Page::ContainsPacketFlags Ogg::Page::containsPacket(int index) const
ContainsPacketFlags flags = DoesNotContainPacket;
if(index == d->firstPacketIndex)
flags = ContainsPacketFlags(flags | BeginsWithPacket);
flags = static_cast<ContainsPacketFlags>(flags | BeginsWithPacket);
if(index == lastPacketIndex)
flags = ContainsPacketFlags(flags | EndsWithPacket);
flags = static_cast<ContainsPacketFlags>(flags | EndsWithPacket);
// If there's only one page and it's complete:
@ -114,7 +114,7 @@ Ogg::Page::ContainsPacketFlags Ogg::Page::containsPacket(int index) const
!d->header.firstPacketContinued() &&
d->header.lastPacketCompleted())
{
flags = ContainsPacketFlags(flags | CompletePacket);
flags = static_cast<ContainsPacketFlags>(flags | CompletePacket);
}
// Or if there is more than one page and the page is
@ -126,7 +126,7 @@ Ogg::Page::ContainsPacketFlags Ogg::Page::containsPacket(int index) const
(flags & EndsWithPacket && d->header.lastPacketCompleted()) ||
(!(flags & BeginsWithPacket) && !(flags & EndsWithPacket))))
{
flags = ContainsPacketFlags(flags | CompletePacket);
flags = static_cast<ContainsPacketFlags>(flags | CompletePacket);
}
return flags;

6
taglib/ogg/oggpageheader.cpp
View File

@ -183,7 +183,7 @@ ByteVector Ogg::PageHeader::render() const
// stream structure version
data.append(char(0));
data.append(static_cast<char>(0));
// header type flag
@ -192,7 +192,7 @@ ByteVector Ogg::PageHeader::render() const
flags[1] = d->pageSequenceNumber == 0;
flags[2] = d->lastPageOfStream;
data.append(char(flags.to_ulong()));
data.append(static_cast<char>(flags.to_ulong()));
// absolute granular position
@ -262,7 +262,7 @@ void Ogg::PageHeader::read(Ogg::File *file, long pageOffset)
// Another sanity check.
if(pageSegmentCount < 1 || int(pageSegments.size()) != pageSegmentCount)
if(pageSegmentCount < 1 || static_cast<int>(pageSegments.size()) != pageSegmentCount)
return;
// The base size of an Ogg page 27 bytes plus the number of lacing values.

2
taglib/ogg/xiphcomment.cpp
View File

@ -408,7 +408,7 @@ ByteVector Ogg::XiphComment::render(bool addFramingBit) const
// Append the "framing bit".
if(addFramingBit)
data.append(char(1));
data.append(static_cast<char>(1));
return data;
}