From 9427d8f3ba898ea39fcc4b5222940e7b3cbd13ff Mon Sep 17 00:00:00 2001 From: Rosen Penev Date: Sat, 26 Nov 2022 22:30:24 -0800 Subject: [PATCH] clang-tidy: use patentheses in macros Found with bugprone-macro-parentheses Signed-off-by: Rosen Penev --- taglib/toolkit/trefcounter.cpp | 4 ++-- taglib/toolkit/tstring.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/taglib/toolkit/trefcounter.cpp b/taglib/toolkit/trefcounter.cpp index bbbac0ba..e61d24c6 100644 --- a/taglib/toolkit/trefcounter.cpp +++ b/taglib/toolkit/trefcounter.cpp @@ -31,8 +31,8 @@ #if defined(HAVE_GCC_ATOMIC) # define ATOMIC_INT int -# define ATOMIC_INC(x) __sync_add_and_fetch(&x, 1) -# define ATOMIC_DEC(x) __sync_sub_and_fetch(&x, 1) +# define ATOMIC_INC(x) __sync_add_and_fetch(&(x), 1) +# define ATOMIC_DEC(x) __sync_sub_and_fetch(&(x), 1) #elif defined(HAVE_WIN_ATOMIC) # if !defined(NOMINMAX) # define NOMINMAX diff --git a/taglib/toolkit/tstring.h b/taglib/toolkit/tstring.h index d34b2012..339e622e 100644 --- a/taglib/toolkit/tstring.h +++ b/taglib/toolkit/tstring.h @@ -45,7 +45,7 @@ #if defined(QT_VERSION) && (QT_VERSION >= 0x040000) #define QStringToTString(s) TagLib::String(s.toUtf8().data(), TagLib::String::UTF8) #else -#define QStringToTString(s) TagLib::String(s.utf8().data(), TagLib::String::UTF8) +#define QStringToTString(s) TagLib::String((s).utf8().data(), TagLib::String::UTF8) #endif /*! @@ -58,7 +58,7 @@ * */ -#define TStringToQString(s) QString::fromUtf8(s.toCString(true)) +#define TStringToQString(s) QString::fromUtf8((s).toCString(true)) namespace TagLib {