mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-07-21 14:34:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Avoid using String::null where an empty string is required.

Browse Source 
String::null is not necessarily be empty or remains the same instance.
Using it in a public header may lead to a linkage error.
This commit is contained in:
Tsuda Kageyu
2015-11-20 22:21:47 +09:00
parent c4fe65787c
commit 8c6fe45453
29 changed files with 106 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
taglib/xm/xmfile.cpp
View File

@ -449,7 +449,7 @@ bool XM::File::save()
seek(pos + 4);
const uint len = std::min(22UL, instrumentHeaderSize - 4U);
if(i >= lines.size())
writeString(String::null, len);
writeString(String(), len);
else
writeString(lines[i], len);
@ -480,7 +480,7 @@ bool XM::File::save()
seek(pos + 18);
const uint len = std::min(sampleHeaderSize - 18U, 22UL);
if(sampleNameIndex >= lines.size())
writeString(String::null, len);
writeString(String(), len);
else
writeString(lines[sampleNameIndex ++], len);
}