mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-07-18 21:14:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix issues reported by CppCheck

Browse Source 
Many shadowFunction, some useStlAlgorithm, and others.

cppcheck --enable=all --inline-suppr \
  --suppress=noExplicitConstructor --suppress=unusedFunction \
  --suppress=missingIncludeSystem --project=compile_commands.json
This commit is contained in:
Urs Fleisch
2023-12-03 11:59:24 +01:00
parent 131918333b
commit 8b3f1a459e
38 changed files with 349 additions and 354 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/test_id3v2framefactory.cpp
View File

@ -74,9 +74,8 @@ namespace
}
private:
CustomFrame(const ByteVector &data, Header *h) : Frame(h) {
parseFields(fieldData(data));
}
CustomFrame(const ByteVector &data, Header *h)
: Frame(h), m_value(fieldData(data).toUInt()) {}
unsigned int m_value;
};

2
tests/test_mod.cpp
View File

@ -79,7 +79,7 @@ public:
testRead(copy.fileName().c_str(), titleAfter, commentAfter);
CPPUNIT_ASSERT(fileEqual(
copy.fileName(),
TEST_FILE_PATH_C("changed.mod")));
testFilePath("changed.mod")));
}
void testPropertyInterface()

2
tests/test_mp4.cpp
View File

@ -714,7 +714,7 @@ public:
CPPUNIT_ASSERT(f.tag()->isEmpty());
CPPUNIT_ASSERT(fileEqual(
copy.fileName(),
TEST_FILE_PATH_C("no-tags.m4a")));
testFilePath("no-tags.m4a")));
}
}

2
tests/test_s3m.cpp
View File

@ -83,7 +83,7 @@ public:
testRead(copy.fileName().c_str(), titleAfter, commentAfter);
CPPUNIT_ASSERT(fileEqual(
copy.fileName(),
TEST_FILE_PATH_C("changed.s3m")));
testFilePath("changed.s3m")));
}
private:

1
tests/test_tag_c.cpp
View File

@ -108,6 +108,7 @@ public:
taglib_property_set_append(file, "COMPOSER", "Composer 2");
taglib_property_set(file, "ALBUMARTIST", "Album Artist");
// cppcheck-suppress cstyleCast
TAGLIB_COMPLEX_PROPERTY_PICTURE(props, "JPEG Data", 9, "Written by TagLib",
"image/jpeg", "Front Cover");
taglib_complex_property_set(file, "PICTURE", props);

2
tests/test_xm.cpp
View File

@ -216,7 +216,7 @@ private:
commentAfter, trackerNameAfter);
CPPUNIT_ASSERT(fileEqual(
copy.fileName(),
TEST_FILE_PATH_C("changed.xm")));
testFilePath("changed.xm")));
}
};