diff --git a/taglib/ogg/opus/opusproperties.cpp b/taglib/ogg/opus/opusproperties.cpp index d7561b90..eb626ff7 100644 --- a/taglib/ogg/opus/opusproperties.cpp +++ b/taglib/ogg/opus/opusproperties.cpp @@ -29,6 +29,8 @@ #include "opusproperties.h" +#include + #include "tstring.h" #include "tdebug.h" #include "oggpageheader.h" @@ -153,8 +155,18 @@ void Opus::Properties::read(File *file) for (unsigned int i = 0; i < 2; ++i) { fileLengthWithoutOverhead -= file->packet(i).size(); } - d->length = static_cast(length + 0.5); - d->bitrate = static_cast(static_cast(fileLengthWithoutOverhead) * 8.0 / length + 0.5); + // The granule positions are 64 bit, so even at the fixed 48 kHz clock + // the millisecond length can land outside int, and a short stream does + // the same to the bitrate. Converting a double the destination type + // cannot represent is undefined, so leave the field at its default + // instead. + if(length > 0.0 && length < static_cast(std::numeric_limits::max())) { + d->length = static_cast(length + 0.5); + + const double bitrate = static_cast(fileLengthWithoutOverhead) * 8.0 / length; + if(bitrate >= 0.0 && bitrate < static_cast(std::numeric_limits::max())) + d->bitrate = static_cast(bitrate + 0.5); + } } } else {