Inspection: Code redundancies

This commit is contained in:
Urs Fleisch
2024-01-20 23:30:40 +01:00
parent 580b0b0c82
commit 7bcfb96098
51 changed files with 154 additions and 164 deletions

View File

@ -37,7 +37,7 @@
int main(int argc, char* argv[])
{
std::string testPath = (argc > 1) ? std::string(argv[1]) : "";
std::string testPath = argc > 1 ? std::string(argv[1]) : "";
// Create the event manager and test controller
CppUnit::TestResult controller;

View File

@ -63,7 +63,7 @@ public:
Map<String, int> m2 = m1;
auto it = m2.find("bob");
(*it).second = 99;
it->second = 99;
CPPUNIT_ASSERT_EQUAL(9, m1["bob"]);
CPPUNIT_ASSERT_EQUAL(99, m2["bob"]);
}

View File

@ -183,10 +183,10 @@ public:
Vorbis::File f(newname.c_str());
List<FLAC::Picture *> lst = f.tag()->pictureList();
CPPUNIT_ASSERT_EQUAL(static_cast<unsigned int>(1), lst.size());
CPPUNIT_ASSERT_EQUAL(static_cast<int>(5), lst[0]->width());
CPPUNIT_ASSERT_EQUAL(static_cast<int>(6), lst[0]->height());
CPPUNIT_ASSERT_EQUAL(static_cast<int>(16), lst[0]->colorDepth());
CPPUNIT_ASSERT_EQUAL(static_cast<int>(7), lst[0]->numColors());
CPPUNIT_ASSERT_EQUAL(5, lst[0]->width());
CPPUNIT_ASSERT_EQUAL(6, lst[0]->height());
CPPUNIT_ASSERT_EQUAL(16, lst[0]->colorDepth());
CPPUNIT_ASSERT_EQUAL(7, lst[0]->numColors());
CPPUNIT_ASSERT_EQUAL(String("image/jpeg"), lst[0]->mimeType());
CPPUNIT_ASSERT_EQUAL(String("new image"), lst[0]->description());
CPPUNIT_ASSERT_EQUAL(ByteVector("JPEG data"), lst[0]->data());