unused includes (#1133)

* unused includes

Signed-off-by: Rosen Penev <[email protected]>

* Use consistent order of includes

Always include in the following order:
- Own header files
- Standard header files
- System header files
- Project header files (toolkit first)

Exceptions:
- cppunit/extensions/HelperMacros.h must be included after
  header files declaring stream operators
- config.h must be included before its definitions are used

---------

Signed-off-by: Rosen Penev <[email protected]>
Co-authored-by: Urs Fleisch <[email protected]>

taglib/ogg/flac/oggflacfile.cpp

@@ -25,14 +25,10 @@
 
 #include "oggflacfile.h"
 
-#include "tbytevector.h"
-#include "tstring.h"
 #include "tdebug.h"
 #include "tpropertymap.h"
 #include "tagutils.h"
 
-#include "xiphcomment.h"
-
 using namespace TagLib;
 using TagLib::FLAC::Properties;
 

taglib/ogg/flac/oggflacfile.h

@@ -29,7 +29,6 @@
 #include "taglib_export.h"
 #include "oggfile.h"
 #include "xiphcomment.h"
-
 #include "flacproperties.h"
 
 namespace TagLib {

taglib/ogg/oggfile.cpp

@@ -25,16 +25,13 @@
 
 #include "oggfile.h"
 
-#include "tbytevectorlist.h"
-#include "tmap.h"
-#include "tstring.h"
-#include "tdebug.h"
+#include <utility>
 
+#include "tdebug.h"
+#include "tmap.h"
 #include "oggpage.h"
 #include "oggpageheader.h"
 
-#include <utility>
-
 using namespace TagLib;
 
 namespace

taglib/ogg/oggfile.h

@@ -23,9 +23,9 @@
  *   http://www.mozilla.org/MPL/                                           *
  ***************************************************************************/
 
-#include "taglib_export.h"
 #include "tfile.h"
 #include "tbytevectorlist.h"
+#include "taglib_export.h"
 
 #ifndef TAGLIB_OGGFILE_H
 #define TAGLIB_OGGFILE_H

taglib/ogg/oggpage.cpp

@@ -31,7 +31,6 @@
 
 #include "tstring.h"
 #include "tdebug.h"
-
 #include "oggpageheader.h"
 #include "oggfile.h"
 

taglib/ogg/oggpage.h

@@ -26,8 +26,8 @@
 #ifndef TAGLIB_OGGPAGE_H
 #define TAGLIB_OGGPAGE_H
 
-#include "taglib_export.h"
 #include "tbytevectorlist.h"
+#include "taglib_export.h"
 
 namespace TagLib {
 

taglib/ogg/oggpageheader.cpp

@@ -27,10 +27,8 @@
 
 #include <bitset>
 
-#include "tstring.h"
 #include "tdebug.h"
-#include "taglib.h"
-
+#include "tstring.h"
 #include "oggfile.h"
 
 using namespace TagLib;

taglib/ogg/opus/opusfile.cpp

@@ -29,7 +29,6 @@
 
 #include "opusfile.h"
 
-#include "tstring.h"
 #include "tdebug.h"
 #include "tpropertymap.h"
 #include "tagutils.h"

taglib/ogg/opus/opusfile.h

@@ -32,7 +32,6 @@
 
 #include "oggfile.h"
 #include "xiphcomment.h"
-
 #include "opusproperties.h"
 
 namespace TagLib {

taglib/ogg/opus/opusproperties.cpp

@@ -31,9 +31,7 @@
 
 #include "tstring.h"
 #include "tdebug.h"
-
 #include "oggpageheader.h"
-
 #include "opusfile.h"
 
 using namespace TagLib;

taglib/ogg/speex/speexfile.cpp

@@ -29,7 +29,6 @@
 
 #include "speexfile.h"
 
-#include "tstring.h"
 #include "tdebug.h"
 #include "tpropertymap.h"
 #include "tagutils.h"

taglib/ogg/speex/speexfile.h

@@ -32,7 +32,6 @@
 
 #include "oggfile.h"
 #include "xiphcomment.h"
-
 #include "speexproperties.h"
 
 namespace TagLib {

taglib/ogg/speex/speexproperties.cpp

@@ -31,9 +31,7 @@
 
 #include "tstring.h"
 #include "tdebug.h"
-
 #include "oggpageheader.h"
-
 #include "speexfile.h"
 
 using namespace TagLib;

taglib/ogg/vorbis/vorbisfile.cpp

@@ -25,9 +25,6 @@
 
 #include "vorbisfile.h"
 
-#include <bitset>
-
-#include "tstring.h"
 #include "tdebug.h"
 #include "tpropertymap.h"
 #include "tagutils.h"

taglib/ogg/vorbis/vorbisfile.h

@@ -29,7 +29,6 @@
 #include "taglib_export.h"
 #include "oggfile.h"
 #include "xiphcomment.h"
-
 #include "vorbisproperties.h"
 
 namespace TagLib {

taglib/ogg/vorbis/vorbisproperties.cpp

@@ -27,9 +27,7 @@
 
 #include "tstring.h"
 #include "tdebug.h"
-
 #include "oggpageheader.h"
-
 #include "vorbisfile.h"
 
 using namespace TagLib;

taglib/ogg/xiphcomment.cpp

@@ -25,14 +25,11 @@
 
 #include "xiphcomment.h"
 
-#include "tbytevector.h"
-#include "tdebug.h"
-
-#include "flacpicture.h"
-#include "tpropertymap.h"
-
 #include <utility>
 
+#include "tdebug.h"
+#include "tpropertymap.h"
+
 using namespace TagLib;
 
 class Ogg::XiphComment::XiphCommentPrivate

taglib/ogg/xiphcomment.h

@@ -26,14 +26,14 @@
 #ifndef TAGLIB_VORBISCOMMENT_H
 #define TAGLIB_VORBISCOMMENT_H
 
-#include "tag.h"
 #include "tlist.h"
 #include "tmap.h"
 #include "tstring.h"
 #include "tstringlist.h"
 #include "tbytevector.h"
-#include "flacpicture.h"
 #include "taglib_export.h"
+#include "tag.h"
+#include "flacpicture.h"
 
 #ifdef _MSC_VER
 // Explained at end of tpropertymap.cpp