mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-07-18 13:04:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

Avoid unnecessary detaching of containers

Browse Source 
If only a constant iterator is needed, make the container const if
possible, otherwise use cbegin() and cend() to get a constant iterator
without detaching the container.

These fixes are needed so that `auto` can deduce the correct
iterator type.
This commit is contained in:
Urs Fleisch
2023-07-15 20:53:49 +02:00
parent b273505c28
commit 63922f2676
42 changed files with 218 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
examples/tagreader.cpp
View File

@ -56,14 +56,14 @@ int main(int argc, char *argv[])
TagLib::PropertyMap tags = f.file()->properties();
unsigned int longest = 0;
for(TagLib::PropertyMap::ConstIterator i = tags.begin(); i != tags.end(); ++i) {
for(TagLib::PropertyMap::ConstIterator i = tags.cbegin(); i != tags.cend(); ++i) {
if (i->first.size() > longest) {
longest = i->first.size();
}
}
cout << "-- TAG (properties) --" << endl;
for(TagLib::PropertyMap::ConstIterator i = tags.begin(); i != tags.end(); ++i) {
for(TagLib::PropertyMap::ConstIterator i = tags.cbegin(); i != tags.cend(); ++i) {
for(TagLib::StringList::ConstIterator j = i->second.begin(); j != i->second.end(); ++j) {
cout << left << std::setw(longest) << i->first << " - " << '"' << *j << '"' << endl;
}

4
examples/tagwriter.cpp
View File

@ -118,7 +118,7 @@ int main(int argc, char *argv[])
TagLib::String value = argv[i + 1];
TagLib::List<TagLib::FileRef>::ConstIterator it;
for(it = fileList.begin(); it != fileList.end(); ++it) {
for(it = fileList.cbegin(); it != fileList.cend(); ++it) {
TagLib::Tag *t = (*it).tag();
@ -178,7 +178,7 @@ int main(int argc, char *argv[])
}
TagLib::List<TagLib::FileRef>::ConstIterator it;
for(it = fileList.begin(); it != fileList.end(); ++it)
for(it = fileList.cbegin(); it != fileList.cend(); ++it)
(*it).file()->save();
return 0;