From 5e37f0101de147b8bf35611cdd5e085e1d576718 Mon Sep 17 00:00:00 2001 From: Tsuda Kageyu Date: Mon, 30 Nov 2015 12:53:52 +0900 Subject: [PATCH] Remove some private data members not needed to be carried. --- taglib/ape/apetag.cpp | 27 ++++++++------------------- taglib/ape/apetag.h | 2 +- 2 files changed, 9 insertions(+), 20 deletions(-) diff --git a/taglib/ape/apetag.cpp b/taglib/ape/apetag.cpp index 170a77c8..71a98c18 100644 --- a/taglib/ape/apetag.cpp +++ b/taglib/ape/apetag.cpp @@ -46,15 +46,7 @@ using namespace APE; class APE::Tag::TagPrivate { public: - TagPrivate() : - file(0), - footerLocation(-1) {} - - TagLib::File *file; - long footerLocation; - Footer footer; - ItemListMap itemListMap; }; @@ -72,10 +64,7 @@ APE::Tag::Tag(TagLib::File *file, long footerLocation) : TagLib::Tag(), d(new TagPrivate()) { - d->file = file; - d->footerLocation = footerLocation; - - read(); + read(file, footerLocation); } APE::Tag::~Tag() @@ -330,19 +319,19 @@ bool APE::Tag::isEmpty() const // protected methods //////////////////////////////////////////////////////////////////////////////// -void APE::Tag::read() +void APE::Tag::read(TagLib::File *file, long footerLocation) { - if(d->file && d->file->isValid()) { + if(file && file->isValid()) { - d->file->seek(d->footerLocation); - d->footer.setData(d->file->readBlock(Footer::size())); + file->seek(footerLocation); + d->footer.setData(file->readBlock(Footer::size())); if(d->footer.tagSize() <= Footer::size() || - d->footer.tagSize() > uint(d->file->length())) + d->footer.tagSize() > uint(file->length())) return; - d->file->seek(d->footerLocation + Footer::size() - d->footer.tagSize()); - parse(d->file->readBlock(d->footer.tagSize() - Footer::size())); + file->seek(footerLocation + Footer::size() - d->footer.tagSize()); + parse(file->readBlock(d->footer.tagSize() - Footer::size())); } } diff --git a/taglib/ape/apetag.h b/taglib/ape/apetag.h index 55572612..6c9999cf 100644 --- a/taglib/ape/apetag.h +++ b/taglib/ape/apetag.h @@ -188,7 +188,7 @@ namespace TagLib { /*! * Reads from the file specified in the constructor. */ - void read(); + void read(TagLib::File *file, long footerLocation); /*! * Parses the body of the tag in \a data.