mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-07-18 21:14:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Unify File constructors with ID3v2::FrameFactory parameter (#1196)

Browse Source 
Make constructors consistent so that the FrameFactory is at the
end and optional. Mark the alternative constructors as deprecated.
This commit is contained in:
Urs Fleisch
2023-12-20 23:22:26 +01:00
parent 0dff3150c1
commit 56fa36934e
8 changed files with 117 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/test_id3v2framefactory.cpp
View File

@ -26,11 +26,14 @@
#include <functional>
#include <memory>
#include "flacproperties.h"
#include "mpegproperties.h"
#include "tbytevector.h"
#include "tpropertymap.h"
#include "mpegfile.h"
#include "flacfile.h"
#include "trueaudiofile.h"
#include "trueaudioproperties.h"
#include "wavfile.h"
#include "aifffile.h"
#include "dsffile.h"
@ -211,7 +214,8 @@ public:
return new MPEG::File(fileName);
},
[](const char *fileName, ID3v2::FrameFactory *factory) {
return new MPEG::File(fileName, factory);
return new MPEG::File(fileName, true, MPEG::Properties::Average,
factory);
},
[](const File &f) {
return static_cast<const MPEG::File &>(f).hasID3v2Tag();
@ -234,7 +238,8 @@ public:
return new FLAC::File(fileName);
},
[](const char *fileName, ID3v2::FrameFactory *factory) {
return new FLAC::File(fileName, factory);
return new FLAC::File(fileName, true, FLAC::Properties::Average,
factory);
},
[](const File &f) {
return static_cast<const FLAC::File &>(f).hasID3v2Tag();
@ -258,7 +263,8 @@ public:
return new TrueAudio::File(fileName);
},
[](const char *fileName, ID3v2::FrameFactory *factory) {
return new TrueAudio::File(fileName, factory);
return new TrueAudio::File(fileName, true,
TrueAudio::Properties::Average, factory);
},
[](const File &f) {
return static_cast<const TrueAudio::File &>(f).hasID3v2Tag();