Verify the ID3v2 version and revision are not 0xFF (#1301)

This commit is contained in:
Stephen Booth
2026-01-31 01:21:17 -06:00
committed by GitHub
parent 11e3eb05bd
commit 51f431c96a
2 changed files with 24 additions and 1 deletions

View File

@ -139,6 +139,7 @@ class TestID3v2 : public CppUnit::TestFixture
CPPUNIT_TEST(testEmptyFrame);
CPPUNIT_TEST(testDuplicateTags);
CPPUNIT_TEST(testParseTOCFrameWithManyChildren);
CPPUNIT_TEST(testInvalidID3v2Version);
CPPUNIT_TEST_SUITE_END();
public:
@ -1739,6 +1740,21 @@ public:
CPPUNIT_ASSERT(tocFrame->embeddedFrameList().isEmpty());
}
void testInvalidID3v2Version()
{
ID3v2::Header invalidVersionHeader(ByteVector("ID3"
"\xFF\x00"
"\x05"
"\x14\x4F\x00\x32", 10));
CPPUNIT_ASSERT_EQUAL(invalidVersionHeader.tagSize(), 0U);
ID3v2::Header invalidRevisionHeader(ByteVector("ID3"
"\x04\xFF"
"\x05"
"\x14\x4F\x00\x32", 10));
CPPUNIT_ASSERT_EQUAL(invalidRevisionHeader.tagSize(), 0U);
}
};
CPPUNIT_TEST_SUITE_REGISTRATION(TestID3v2);