mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-07-19 13:34:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

FilePrivate is responsible to delete a stream pointer instead of File.

Browse Source 
Generally, TagLib leaves the Private classes to delete their members.
This commit is contained in:
Tsuda Kageyu
2017-02-08 17:45:46 +09:00
parent dd4adf94ce
commit 45ee18e206
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
taglib/toolkit/tfile.cpp
View File

@ -69,20 +69,22 @@ using namespace TagLib;
class File::FilePrivate
{
public:
FilePrivate(IOStream *stream, bool owner);
FilePrivate(IOStream *stream, bool owner) :
stream(stream),
streamOwner(owner),
valid(true) {}
~FilePrivate()
{
if(streamOwner)
delete stream;
}
IOStream *stream;
bool streamOwner;
bool valid;
};
File::FilePrivate::FilePrivate(IOStream *stream, bool owner) :
stream(stream),
streamOwner(owner),
valid(true)
{
}
////////////////////////////////////////////////////////////////////////////////
// public members
////////////////////////////////////////////////////////////////////////////////
@ -99,8 +101,6 @@ File::File(IOStream *stream) :
File::~File()
{
if(d->stream && d->streamOwner)
delete d->stream;
delete d;
}