From 68ef160dbc8f9e421c39440fa6f0bc4c8f777caf Mon Sep 17 00:00:00 2001 From: Tsuda Kageyu Date: Thu, 18 Jun 2015 11:22:54 +0900 Subject: [PATCH] Fix mismatched file I/O buffer sizes. --- taglib/toolkit/tfile.cpp | 11 +---------- taglib/toolkit/tfilestream.cpp | 4 +--- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/taglib/toolkit/tfile.cpp b/taglib/toolkit/tfile.cpp index af8ec390..a01c3460 100644 --- a/taglib/toolkit/tfile.cpp +++ b/taglib/toolkit/tfile.cpp @@ -66,15 +66,6 @@ using namespace TagLib; -namespace -{ -#ifdef _WIN32 - const TagLib::uint BufferSize = 8192; -#else - const TagLib::uint BufferSize = 1024; -#endif -} - class File::FilePrivate { public: @@ -499,7 +490,7 @@ bool File::isWritable(const char *file) TagLib::uint File::bufferSize() { - return BufferSize; + return 1024; } void File::setValid(bool valid) diff --git a/taglib/toolkit/tfilestream.cpp b/taglib/toolkit/tfilestream.cpp index 93078ae9..4480c274 100644 --- a/taglib/toolkit/tfilestream.cpp +++ b/taglib/toolkit/tfilestream.cpp @@ -45,7 +45,6 @@ namespace typedef FileName FileNameHandle; typedef HANDLE FileHandle; - const TagLib::uint BufferSize = 8192; const FileHandle InvalidFileHandle = INVALID_HANDLE_VALUE; inline FileHandle openFile(const FileName &path, bool readOnly) @@ -93,7 +92,6 @@ namespace typedef FILE* FileHandle; - const TagLib::uint BufferSize = 8192; const FileHandle InvalidFileHandle = 0; inline FileHandle openFile(const FileName &path, bool readOnly) @@ -497,5 +495,5 @@ void FileStream::truncate(long length) TagLib::uint FileStream::bufferSize() { - return BufferSize; + return 1024; }