mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2026-04-12 17:09:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

cppcheck: match function argument names

Browse Source 
Found with funcArgNamesDifferent

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev
2024-01-18 12:41:50 -08:00
committed by Urs Fleisch
parent 769feafbe0
commit 208fc93aaa
9 changed files with 46 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
taglib/mpeg/id3v1/id3v1genres.cpp
View File

@ -247,10 +247,10 @@ ID3v1::GenreMap ID3v1::genreMap()
return m;
}
String ID3v1::genre(int i)
String ID3v1::genre(int index)
{
if(i >= 0 && static_cast<size_t>(i) < genres.size())
return String(genres[i]); // always make a copy
if(index >= 0 && static_cast<size_t>(index) < genres.size())
return String(genres[index]); // always make a copy
return String();
}

16
taglib/mpeg/mpegfile.h
View File

@ -74,14 +74,14 @@ namespace TagLib {
* Constructs an MPEG file from \a file. If \a readProperties is \c true the
* file's audio properties will also be read.
*
* If \a propertiesStyle is not Fast, the file will be scanned
* If \a readStyle is not Fast, the file will be scanned
* completely if no ID3v2 tag or MPEG sync code is found at the start.
*
* If this file contains an ID3v2 tag, the frames will be created using
* \a frameFactory (default if null).
*/
File(FileName file, bool readProperties = true,
Properties::ReadStyle propertiesStyle = Properties::Average,
Properties::ReadStyle readStyle = Properties::Average,
ID3v2::FrameFactory *frameFactory = nullptr);
/*!
@ -91,7 +91,7 @@ namespace TagLib {
* If this file contains an ID3v2 tag, the frames will be created using
* \a frameFactory.
*
* If \a propertiesStyle is not Fast, the file will be scanned
* If \a readStyle is not Fast, the file will be scanned
* completely if no ID3v2 tag or MPEG sync code is found at the start.
*
* \deprecated Use the constructor above.
@ -99,7 +99,7 @@ namespace TagLib {
TAGLIB_DEPRECATED
File(FileName file, ID3v2::FrameFactory *frameFactory,
bool readProperties = true,
Properties::ReadStyle propertiesStyle = Properties::Average);
Properties::ReadStyle readStyle = Properties::Average);
/*!
* Constructs an MPEG file from \a stream. If \a readProperties is \c true the
@ -111,14 +111,14 @@ namespace TagLib {
* If this file contains an ID3v2 tag, the frames will be created using
* \a frameFactory.
*
* If \a propertiesStyle is not Fast, the file will be scanned
* If \a readStyle is not Fast, the file will be scanned
* completely if no ID3v2 tag or MPEG sync code is found at the start.
*
* If this file contains an ID3v2 tag, the frames will be created using
* \a frameFactory (default if null).
*/
File(IOStream *stream, bool readProperties = true,
Properties::ReadStyle propertiesStyle = Properties::Average,
Properties::ReadStyle readStyle = Properties::Average,
ID3v2::FrameFactory *frameFactory = nullptr);
/*!
@ -131,7 +131,7 @@ namespace TagLib {
* If this file contains an ID3v2 tag, the frames will be created using
* \a frameFactory.
*
* If \a propertiesStyle is not Fast, the file will be scanned
* If \a readStyle is not Fast, the file will be scanned
* completely if no ID3v2 tag or MPEG sync code is found at the start.
*
* \deprecated Use the constructor above.
@ -139,7 +139,7 @@ namespace TagLib {
TAGLIB_DEPRECATED
File(IOStream *stream, ID3v2::FrameFactory *frameFactory,
bool readProperties = true,
Properties::ReadStyle propertiesStyle = Properties::Average);
Properties::ReadStyle readStyle = Properties::Average);
/*!
* Destroys this instance of the File.