From 2044b316982371dce9104982a82f2db19284e7f8 Mon Sep 17 00:00:00 2001 From: "Stephen F. Booth" Date: Sun, 17 Dec 2023 18:01:53 -0600 Subject: [PATCH] Fix chunk ID validation According to EA IFF 85: Type IDs A "type ID", "property name", "FORM type", or any other IFF identifier is a 32-bit value: the concatenation of four ASCII characters in the range R S (SP, hex 20) through R~S (hex 7E). Spaces (hex 20) should not precede printing characters; trailing spaces are ok. Control characters are forbidden. --- taglib/dsdiff/dsdifffile.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/taglib/dsdiff/dsdifffile.cpp b/taglib/dsdiff/dsdifffile.cpp index 28c25498..18afe264 100644 --- a/taglib/dsdiff/dsdifffile.cpp +++ b/taglib/dsdiff/dsdifffile.cpp @@ -66,7 +66,7 @@ namespace return false; for(int i = 0; i < 4; i++) { - if(name[i] < 32 /*|| name[i] > 127*/) + if(name[i] < 32 || name[i] > 126) return false; }