mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-07-14 02:54:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Several optimizations that came from KCacheGrind / calltree fun.

Browse Source 
Basically they fall into the categories:
- Don't convert things before you need to
- When you do, use more effecient copy constructors / assignment operators
  (i.e. when copying prefer memcpy to a for loop and when that's not possible
  use an iterator instead of operator[])


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301896 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
This commit is contained in:
Scott Wheeler
2004-04-07 06:00:05 +00:00
parent 1bc8909bba
commit 15d3c3c71a
4 changed files with 66 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
toolkit/tstring.cpp
View File

@ -88,8 +88,14 @@ String::String(const std::string &s, Type t)
return;
}
for(std::string::const_iterator it = s.begin(); it != s.end(); it++)
d->data += uchar(*it);
int length = s.length();
d->data.resize(length);
wstring::iterator targetIt = d->data.begin();
for(std::string::const_iterator it = s.begin(); it != s.end(); it++) {
*targetIt = uchar(*it);
++targetIt;
}
prepare(t);
}
@ -115,8 +121,15 @@ String::String(const char *s, Type t)
return;
}
for(int i = 0; s[i] != 0; i++)
d->data += uchar(s[i]);
int length = ::strlen(s);
d->data.resize(length);
wstring::iterator targetIt = d->data.begin();
for(int i = 0; i < length; i++) {
*targetIt = uchar(s[i]);
++targetIt;
}
prepare(t);
}
@ -146,12 +159,25 @@ String::String(const ByteVector &v, Type t)
d = new StringPrivate;
if(t == Latin1 || t == UTF8) {
for(uint i = 0; i < v.size() && v[i]; i++)
d->data += uchar(v[i]);
d->data.resize(v.size());
wstring::iterator targetIt = d->data.begin();
for(ByteVector::ConstIterator it = v.begin(); it != v.end() && (*it); ++it) {
*targetIt = uchar(*it);
++targetIt;
}
}
else {
for(uint i = 0; i + 1 < v.size() && combine(v[i], v[i + 1]); i += 2)
d->data += combine(v[i], v[i + 1]);
d->data.resize(v.size() / 2);
wstring::iterator targetIt = d->data.begin();
for(ByteVector::ConstIterator it = v.begin();
it + 1 != v.end() && combine(*it, *(it + 1));
it += 2)
{
*targetIt = combine(*it, *(it + 1));
++targetIt;
}
}
prepare(t);
}
@ -516,8 +542,14 @@ String &String::operator=(const char *s)
d = new StringPrivate;
for(int i = 0; s[i] != 0; i++)
d->data += uchar(s[i]);
int length = ::strlen(s);
d->data.resize(length);
wstring::iterator targetIt = d->data.begin();
for(int i = 0; i < length; i++) {
*targetIt = uchar(s[i]);
++targetIt;
}
return *this;
}
@ -532,9 +564,11 @@ String &String::operator=(const ByteVector &v)
wstring::iterator targetIt = d->data.begin();
uint i = 0;
for(; i < v.size() && v[i]; i++) {
*targetIt = uchar(v[i]);
for(ByteVector::ConstIterator it = v.begin(); it != v.end() && (*it); ++it) {
*targetIt = uchar(*it);
++targetIt;
++i;
}
// If we hit a null in the ByteVector, shrink the string again.