From 0a85f9b227db1432ae3fa27b235ec806b9ad3cf6 Mon Sep 17 00:00:00 2001 From: Tsuda Kageyu Date: Fri, 22 Apr 2016 09:27:04 +0900 Subject: [PATCH] Revert "Hide a private static variable." This reverts commit 25ffbcb4b9b04326edd1d25a785b686951a0f235. # Conflicts: # taglib/mpeg/id3v2/id3v2framefactory.cpp # taglib/mpeg/id3v2/id3v2framefactory.h --- taglib/mpeg/id3v2/id3v2framefactory.cpp | 4 ++-- taglib/mpeg/id3v2/id3v2framefactory.h | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/taglib/mpeg/id3v2/id3v2framefactory.cpp b/taglib/mpeg/id3v2/id3v2framefactory.cpp index bbeb56f0..0fbb87d0 100644 --- a/taglib/mpeg/id3v2/id3v2framefactory.cpp +++ b/taglib/mpeg/id3v2/id3v2framefactory.cpp @@ -102,13 +102,14 @@ public: } }; +FrameFactory FrameFactory::factory; + //////////////////////////////////////////////////////////////////////////////// // public members //////////////////////////////////////////////////////////////////////////////// FrameFactory *FrameFactory::instance() { - static FrameFactory factory; return &factory; } @@ -538,4 +539,3 @@ bool FrameFactory::updateFrame(Frame::Header *header) const return true; } - diff --git a/taglib/mpeg/id3v2/id3v2framefactory.h b/taglib/mpeg/id3v2/id3v2framefactory.h index c3875dc5..33c7f67e 100644 --- a/taglib/mpeg/id3v2/id3v2framefactory.h +++ b/taglib/mpeg/id3v2/id3v2framefactory.h @@ -66,7 +66,6 @@ namespace TagLib { { public: static FrameFactory *instance(); - /*! * Create a frame based on \a data. \a synchSafeInts should only be set * false if we are parsing an old tag (v2.3 or older) that does not support @@ -153,6 +152,8 @@ namespace TagLib { FrameFactory(const FrameFactory &); FrameFactory &operator=(const FrameFactory &); + static FrameFactory factory; + class FrameFactoryPrivate; FrameFactoryPrivate *d; };