From 0178d47c852d760aa3d6aba07c6f607d0163f76f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luk=C3=A1=C5=A1=20Lalinsk=C3=BD?= Date: Sun, 23 Aug 2015 12:10:12 +0200 Subject: [PATCH] Don't use const ref to an integer in ChapterFrame --- taglib/mpeg/id3v2/frames/chapterframe.cpp | 4 ++-- taglib/mpeg/id3v2/frames/chapterframe.h | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/taglib/mpeg/id3v2/frames/chapterframe.cpp b/taglib/mpeg/id3v2/frames/chapterframe.cpp index ad471ecd..e11e2928 100644 --- a/taglib/mpeg/id3v2/frames/chapterframe.cpp +++ b/taglib/mpeg/id3v2/frames/chapterframe.cpp @@ -65,8 +65,8 @@ ChapterFrame::ChapterFrame(const ID3v2::Header *tagHeader, const ByteVector &dat } ChapterFrame::ChapterFrame(const ByteVector &elementID, - const TagLib::uint &startTime, const TagLib::uint &endTime, - const TagLib::uint &startOffset, const TagLib::uint &endOffset, + TagLib::uint startTime, TagLib::uint endTime, + TagLib::uint startOffset, TagLib::uint endOffset, const FrameList &embeddedFrames) : ID3v2::Frame("CHAP") { diff --git a/taglib/mpeg/id3v2/frames/chapterframe.h b/taglib/mpeg/id3v2/frames/chapterframe.h index 692895ee..36853062 100644 --- a/taglib/mpeg/id3v2/frames/chapterframe.h +++ b/taglib/mpeg/id3v2/frames/chapterframe.h @@ -61,10 +61,9 @@ namespace TagLib { * * All times are in milliseconds. */ - // BIC: There's no reason to use const-references with uints ChapterFrame(const ByteVector &elementID, - const uint &startTime, const uint &endTime, - const uint &startOffset, const uint &endOffset, + uint startTime, uint endTime, + uint startOffset, uint endOffset, const FrameList &embeddedFrames = FrameList()); /*!