From eb61fcb1307f3ec9d38c78be32e6d5a158004ae1 Mon Sep 17 00:00:00 2001
From: vsariola <5684185+vsariola@users.noreply.github.com>
Date: Sat, 20 Mar 2021 18:46:10 +0200
Subject: [PATCH] fix(vm): parameters with default values (no key in the unit
 parameter map) were not considered to be used in featureset

---
 vm/featureset.go | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/vm/featureset.go b/vm/featureset.go
index 8b38817..bbb6945 100644
--- a/vm/featureset.go
+++ b/vm/featureset.go
@@ -131,8 +131,9 @@ func NecessaryFeaturesFor(patch sointu.Patch) NecessaryFeatures {
 				features.instructions = append(features.instructions, unit.Type)
 				features.opcodes[unit.Type] = len(features.instructions) * 2 // note that the first opcode gets value 1, as 0 is always reserved for advance
 			}
-			for k, v := range unit.Parameters {
-				key := paramKey{unit.Type, k}
+			for _, paramType := range sointu.UnitTypes[unit.Type] {
+				v := unit.Parameters[paramType.Name]
+				key := paramKey{unit.Type, paramType.Name}
 				if features.supportsParamValue[key] == nil {
 					features.supportsParamValue[key] = map[int]bool{}
 				}