From e2c6d4b70c652b662f3f27abd92ec0f23901bd88 Mon Sep 17 00:00:00 2001 From: Veikko Sariola Date: Fri, 20 Nov 2020 22:54:33 +0200 Subject: [PATCH] fix(CI): Cgo linker flags stopped working. They caused the tests to fail completely, but without them, the builds only give some warnings. So disabling them for now. --- .github/workflows/tests.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index af1dcac..8a94952 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -34,7 +34,10 @@ jobs: maker: ninja asmnasm: /Users/runner/nasm/nasm gotests: yes - cgo_ldflags: -Wl,-no_pie # ld on mac is complaining about position dependent code + cgo_ldflags: # -Wl,-no_pie + # ld on mac is complaining about position dependent code so this would take the errors away, BUT + # suddenly this causes an error, even though worked last week. Let's accept the warnings rather + # than let the tests fail because of this. # TODO: win32 builds didn't quite work out, complains gcc broken steps: - uses: lukka/get-cmake@v3.18.3