mirror/sointu
1
0
Fork 0
mirror of https://github.com/vsariola/sointu.git synced 2025-05-28 03:10:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(templates): avoid clobbering ebx in su_load_gmdls

Browse Source 
Fixes #130
This commit is contained in:
5684185+vsariola@users.noreply.github.com 2024-02-16 20:06:28 +02:00
parent c08a319eb7
commit 6d3c65e11d
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -7,6 +7,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
### Added ### Added
- Dbgain unit, which allows defining the gain in decibels (-40 dB to +40dB) - Dbgain unit, which allows defining the gain in decibels (-40 dB to +40dB)
### Fixed
- 32-bit su_load_gmdls clobbered ebx, even though __stdcall demands it to be not
touched
## v0.3.0 ## v0.3.0
### Added ### Added
- Scroll bars to menus, shown when a menu is too long to fit. - Scroll bars to menus, shown when a menu is too long to fit.

16
vm/compiler/templates/amd64-386/gmdls.asm
View File

@ -23,15 +23,17 @@
add rsp, 40 ; shadow space, as required by Win64 ABI add rsp, 40 ; shadow space, as required by Win64 ABI
ret ret
{{else}} {{else}}
mov ebx, su_sample_table mov eax, su_sample_table
push 0 ; OF_READ ; these are the arguments for ReadFile
push ebx ; &ofstruct, blatantly reuse the sample table
push su_gmdls_path1 ; path
call dword [__imp__OpenFile@12]; eax = OpenFile(path,&ofstruct,OF_READ) // should not touch ebx according to calling convention
push 0 ; NULL push 0 ; NULL
push ebx ; &bytes_read, reusing sample table again; it does not matter that the first four bytes are trashed push eax ; &bytes_read, reusing sample table again; it does not matter that the first four bytes are trashed
push 3440660 ; number of bytes to read push 3440660 ; number of bytes to read
push ebx ; here we actually pass the sample table to readfile push eax ; here we actually pass the sample table to readfile
; these are for OpenFile
push 0 ; OF_READ
push eax ; &ofstruct, blatantly reuse the sample table
push su_gmdls_path1 ; path
call dword [__imp__OpenFile@12]; eax = OpenFile(path,&ofstruct,OF_READ)
push eax ; handle to file push eax ; handle to file
call dword [__imp__ReadFile@20] ; Readfile(handle,&su_sample_table,SAMPLE_TABLE_SIZE,&bytes_read,NULL) call dword [__imp__ReadFile@20] ; Readfile(handle,&su_sample_table,SAMPLE_TABLE_SIZE,&bytes_read,NULL)
ret ret