From 6629a9fdfa56c6e175aad4ef511378dcf8c5a3d9 Mon Sep 17 00:00:00 2001 From: "5684185+vsariola@users.noreply.github.com" <5684185+vsariola@users.noreply.github.com> Date: Wed, 21 Jan 2026 20:45:03 +0200 Subject: [PATCH] refactor(tracker): add MakeBoolFromPtr constructor for Bool --- tracker/bool.go | 12 ++++++++---- tracker/spectrum.go | 2 +- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/tracker/bool.go b/tracker/bool.go index d3b64a3..533ea7e 100644 --- a/tracker/bool.go +++ b/tracker/bool.go @@ -40,6 +40,10 @@ func MakeBool(value BoolValue) Bool { return Bool{value: value} } +func MakeBoolFromPtr(value *bool) Bool { + return Bool{value: (*simpleBool)(value)} +} + func (v Bool) Toggle() { v.SetValue(!v.Value()) } @@ -190,7 +194,7 @@ func (m *Playing) Enabled() bool { return m.playing || !m.instrEnlarged } // InstrEnlarged methods -func (m *Model) InstrEnlarged() Bool { return MakeBool((*simpleBool)(&m.instrEnlarged)) } +func (m *Model) InstrEnlarged() Bool { return MakeBoolFromPtr(&m.instrEnlarged) } // InstrEditor methods @@ -220,7 +224,7 @@ func (m *InstrPresets) SetValue(val bool) { // Follow methods -func (m *Model) Follow() Bool { return MakeBool((*simpleBool)(&m.follow)) } +func (m *Model) Follow() Bool { return MakeBoolFromPtr(&m.follow) } // TrackMidiIn (Midi Input for notes in the tracks) @@ -320,7 +324,7 @@ func (t *LoopToggle) SetValue(val bool) { // UniquePatterns methods -func (m *Model) UniquePatterns() Bool { return MakeBool((*simpleBool)(&m.uniquePatterns)) } +func (m *Model) UniquePatterns() Bool { return MakeBoolFromPtr(&m.uniquePatterns) } // Mute methods func (m *Model) Mute() Bool { return MakeBool((*Mute)(m)) } @@ -374,4 +378,4 @@ func (m *Solo) Enabled() bool { return m.d.InstrIndex >= 0 && m.d.InstrIndex < l // LinkInstrTrack methods -func (m *Model) LinkInstrTrack() Bool { return MakeBool((*simpleBool)(&m.linkInstrTrack)) } +func (m *Model) LinkInstrTrack() Bool { return MakeBoolFromPtr(&m.linkInstrTrack) } diff --git a/tracker/spectrum.go b/tracker/spectrum.go index 37d326d..9973bd9 100644 --- a/tracker/spectrum.go +++ b/tracker/spectrum.go @@ -58,7 +58,7 @@ const ( NumSpecChnModes ) -func (m *Model) SpecAnEnabled() Bool { return MakeBool((*simpleBool)(&m.specAnEnabled)) } +func (m *Model) SpecAnEnabled() Bool { return MakeBoolFromPtr(&m.specAnEnabled) } func NewSpecAnalyzer(broker *Broker) *SpecAnalyzer { ret := &SpecAnalyzer{broker: broker}