mirror/sointu
1
0
Fork 0
mirror of https://github.com/vsariola/sointu.git synced 2025-07-17 20:44:29 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: rename sointu.Render as AudioBuffer.Fill

Browse Source 
The Render name misleading as it did not do the same thing as normal
Synth.Render, because it disregarded time limits. Conceptually, as
the function modifies the state of the synth, it would be better to
be synth.Fill(audioBuffer), but we cannot define methods on
interfaces; therefore, it is audioBuffer.Fill(synth) now.
This commit is contained in:
5684185+vsariola@users.noreply.github.com
2023-10-19 11:11:42 +03:00
parent ff4155a08e
commit 5bbec75120
4 changed files with 22 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
vm/compiler/bridge/native_synth_test.go
View File

@ -60,12 +60,12 @@ func TestRenderSamples(t *testing.T) {
}
synth.Trigger(0, 64)
buffer := make(sointu.AudioBuffer, su_max_samples)
err = sointu.Render(synth, buffer[:len(buffer)/2])
err = buffer[:len(buffer)/2].Fill(synth)
if err != nil {
t.Fatalf("first render gave an error")
}
synth.Release(0)
err = sointu.Render(synth, buffer[len(buffer)/2:])
err = buffer[len(buffer)/2:].Fill(synth)
if err != nil {
t.Fatalf("first render gave an error")
}
@ -135,7 +135,7 @@ func TestStackUnderflow(t *testing.T) {
t.Fatalf("bridge compile error: %v", err)
}
buffer := make(sointu.AudioBuffer, 1)
err = sointu.Render(synth, buffer)
err = buffer.Fill(synth)
if err == nil {
t.Fatalf("rendering should have failed due to stack underflow")
}
@ -151,7 +151,7 @@ func TestStackBalancing(t *testing.T) {
t.Fatalf("bridge compile error: %v", err)
}
buffer := make(sointu.AudioBuffer, 1)
err = sointu.Render(synth, buffer)
err = buffer.Fill(synth)
if err == nil {
t.Fatalf("rendering should have failed due to unbalanced stack push/pop")
}
@ -184,7 +184,7 @@ func TestStackOverflow(t *testing.T) {
t.Fatalf("bridge compile error: %v", err)
}
buffer := make(sointu.AudioBuffer, 1)
err = sointu.Render(synth, buffer)
err = buffer.Fill(synth)
if err == nil {
t.Fatalf("rendering should have failed due to stack overflow, despite balanced push/pops")
}
@ -201,7 +201,7 @@ func TestDivideByZero(t *testing.T) {
t.Fatalf("bridge compile error: %v", err)
}
buffer := make(sointu.AudioBuffer, 1)
err = sointu.Render(synth, buffer)
err = buffer.Fill(synth)
if err == nil {
t.Fatalf("rendering should have failed due to divide by zero")
}