mirror/sointu
1
0
Fork 0
mirror of https://github.com/vsariola/sointu.git synced 2025-07-18 21:14:31 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(vm/compiler/templates): modulating delaytime in wasm could crash

Browse Source 
The modulated delay time was converted to int with i32.trunc_f32_u.
This throws runtime error if the modulations caused the delaytime
to become negative, because _u implied that it should be unsigned
integer and negative numbers were out of range. Using
i32.trunc_f32_s fixed this.
This commit is contained in:
5684185+vsariola@users.noreply.github.com
2024-04-08 20:06:20 +03:00
parent f074c392f6
commit 4a8d4c5a29
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
vm/compiler/templates/wasm/effects.wat
View File

@ -313,7 +313,7 @@
))
{{- end}}
{{- if .SupportsModulation "delay" "delaytime"}}
(i32.trunc_f32_u (f32.add
(i32.trunc_f32_s (f32.add
(f32.add
(local.get $delayTime)
(f32.mul
@ -324,7 +324,7 @@
(f32.const 0.5)
))
{{- else}}
(i32.trunc_f32_u (f32.add (local.get $delayTime) (f32.const 0.5)))
(i32.trunc_f32_s (f32.add (local.get $delayTime) (f32.const 0.5)))
{{- end}}
{{- else}}
(i32.load16_u