mirror/sointu
1
0
Fork 0
mirror of https://github.com/vsariola/sointu.git synced 2025-07-18 13:04:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(vm/compiler): invert the logic of the release flag in the voices (closes #102)

Browse Source 
This makes all envelopes released by default, instead of attacking. Add also test to demonstrate the buggy behaviour.
This commit is contained in:
5684185+vsariola@users.noreply.github.com
2023-09-02 20:54:37 +03:00
parent 20b0598a57
commit 1ac2ad3c75
13 changed files with 46 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
vm/interpreter.go
View File

@ -41,7 +41,7 @@ type unit struct {
type voice struct {
note byte
release bool
sustain bool
units [MAX_UNITS]unit
}
@ -105,10 +105,11 @@ func (s SynthService) Compile(patch sointu.Patch, bpm int) (sointu.Synth, error)
func (s *Interpreter) Trigger(voiceIndex int, note byte) {
s.synth.voices[voiceIndex] = voice{}
s.synth.voices[voiceIndex].note = note
s.synth.voices[voiceIndex].sustain = true
}
func (s *Interpreter) Release(voiceIndex int) {
s.synth.voices[voiceIndex].release = true
s.synth.voices[voiceIndex].sustain = false
}
func (s *Interpreter) Update(patch sointu.Patch, bpm int) error {
@ -297,7 +298,7 @@ func (s *Interpreter) Render(buffer []float32, maxtime int) (samples int, time i
stack = append(stack, synth.outputs[channel])
synth.outputs[channel] = 0
case opEnvelope:
if voices[0].release {
if !voices[0].sustain {
unit.state[0] = envStateRelease // set state to release
}
state := unit.state[0]