From 6e2c3f160bd02176719513344c7fa2390cad68e8 Mon Sep 17 00:00:00 2001 From: Erno Kilpelainen Date: Fri, 5 Jun 2026 11:02:03 +0000 Subject: [PATCH] Fix Medium Severity Coverity finding: CWE-252 (Ignoring number of bytes read) (https://cwe.mitre.org/data/definitions/252.html) --- tools/fftutil.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/tools/fftutil.c b/tools/fftutil.c index 5445f9d..986ac42 100644 --- a/tools/fftutil.c +++ b/tools/fftutil.c @@ -26,9 +26,16 @@ void fft_file(FILE * fin,FILE * fout,int nfft,int isinverse) bufout = (kiss_fft_cpx*)malloc(sizeof(kiss_fft_cpx) * nfft ); st = kiss_fft_alloc( nfft ,isinverse ,0,0); - while ( fread( buf , sizeof(kiss_fft_cpx) * nfft ,1, fin ) > 0 ) { - kiss_fft( st , buf ,bufout); - fwrite( bufout , sizeof(kiss_fft_cpx) , nfft , fout ); + while (1) { + size_t nread = fread(buf, sizeof(kiss_fft_cpx), nfft, fin); + if (nread == (size_t)nfft) { + kiss_fft( st , buf ,bufout); + fwrite( bufout , sizeof(kiss_fft_cpx) , nfft , fout ); + continue; + } + if (nread != 0) + fprintf(stderr,"short read on complex input\n"); + break; } free(st); free(buf);