Default to build heif support

Heif is now being widely used because of android and iphones
and it's not really nice to discover that even if I have the
library to handle heif, it's not compilling.

.kde-ci.yml

@@ -7,4 +7,4 @@ Dependencies:
 Options:
   test-before-installing: True
   require-passing-tests-on: [ 'Linux', 'FreeBSD', 'Windows' ]
-  cmake-options: "-DKIMAGEFORMATS_DDS=ON -DKIMAGEFORMATS_JXR=ON"
+  cmake-options: "-DKIMAGEFORMATS_JXR=ON"

CMakeLists.txt

@@ -1,11 +1,11 @@
 cmake_minimum_required(VERSION 3.16)
 
 set(KF_VERSION "6.10.0") # handled by release scripts
-set(KF_DEP_VERSION "6.10.0") # handled by release scripts
+set(KF_DEP_VERSION "6.9.0") # handled by release scripts
 project(KImageFormats VERSION ${KF_VERSION})
 
 include(FeatureSummary)
-find_package(ECM 6.10.0  NO_MODULE)
+find_package(ECM 6.9.0  NO_MODULE)
 set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://commits.kde.org/extra-cmake-modules")
 feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES)
 
@@ -62,9 +62,7 @@ set_package_properties(libavif PROPERTIES
     PURPOSE "Required for the QImage plugin for AVIF images"
 )
 
-option(KIMAGEFORMATS_DDS "Enable plugin for DDS format" ON)
+option(KIMAGEFORMATS_HEIF "Enable plugin for HEIF format" ON)
-
-option(KIMAGEFORMATS_HEIF "Enable plugin for HEIF format" OFF)
 if(KIMAGEFORMATS_HEIF)
     pkg_check_modules(LibHeif IMPORTED_TARGET libheif>=1.10.0)
 endif()
@@ -84,7 +82,6 @@ set_package_properties(LibRaw PROPERTIES
     PURPOSE "Required for the QImage plugin for RAW images"
 )
 
-# JXR plugin disabled by default due to security issues
 option(KIMAGEFORMATS_JXR "Enable plugin for JPEG XR format" OFF)
 if(KIMAGEFORMATS_JXR)
     find_package(LibJXR)

README.md

@@ -1,7 +1,6 @@
 # KImageFormats
 
-Plugins to allow [`QImage`](https://doc.qt.io/qt-6/qimage.html) to support
+Plugins to allow `QImage` to support extra file formats.
-extra file formats.
 
 ## Introduction
 
@@ -29,7 +28,6 @@ The following image formats have read-only support:
 The following image formats have read and write support:
 
 - AV1 Image File Format (avif)
-- DirectDraw Surface (dds)
 - Encapsulated PostScript (eps)
 - High Efficiency Image File Format (heif)
 - JPEG XL (jxl)
@@ -43,22 +41,16 @@ The following image formats have read and write support:
 
 ## Contributing
 
-See the [`QImageIOPlugin`](https://doc.qt.io/qt-6/qimageioplugin.html)
+See the [`QImageIOPlugin`](https://doc.qt.io/qt-6/qimageioplugin.html) documentation for information on how to write a
-documentation for information on how to write a new plugin.
+new plugin.
 
-The main difference between this framework and the image formats of Qt is
+The main difference between this framework and the qimageformats module
-the license. As such, if you write an image format plugin and you are
+of Qt is the license.  As such, if you write an imageformat plugin and
-willing to sign the Qt Project contributor agreement, it may be better to
+you are willing to sign the Qt Project contributor agreement, it may be
-submit the plugin directly to the Qt Project.
+better to submit the plugin directly to the Qt Project.
-
-To be accepted, contributions must:
-- Contain the test images needed to verify that the changes work correctly
-- Pass the tests successfully
 
 ## Duplicated Plugins
 
-### The TGA plugin
-
 The TGA plugin supports more formats than Qt's own TGA plugin;
 specifically, the one provided here supports indexed, greyscale and RLE
 images (types 1-3 and 9-11), while Qt's plugin only supports type 2
@@ -69,12 +61,6 @@ licensing.  If anyone were willing to write fresh code to improve Qt's
 TGA plugin, it would allow the TGA plugin in this framework to be
 removed.
 
-### The DDS plugin
-
-The DDS plugin is a fork from Qt 5.6 with bug fixes and improvements.
-
-The plugin was forked because Qt Project no longer supports its DDS plugin.
-
 ## License
 
 This framework is licensed under the
@@ -85,23 +71,22 @@ The CMake code in this framework is licensed under the
 
 ## Plugin status
 
-The current implementation of a plugin may not be complete or may have
+The current implementation of a plugin may not be complete or may have limitations
-limitations of various kinds. Typically the limitations are on maximum size
+of various kinds. Typically the limitations are on maximum size and color depth.
-and color depth.
 
-The various plugins are also limited by the formats natively supported by Qt.
+The various plugins are also limited by the formats natively supported by Qt. 
 For example, native support for CMYK images is only available since Qt 6.8.
 
 ### HDR images
 
-HDR images are supported via floating point image formats from DDS, EXR, HDR,
+HDR images are supported via floating point image formats from EXR, HDR, JXL,
-JXL, JXR, PFM and PSD plugins.
+JXR, PFM and PSD plugins.
-It is important to note that in the past these plugins stripped away HDR
+It is important to note that in the past these plugins stripped away HDR 
 information, returning SDR images.
 
 HDR images return R, G and B values ​​outside the range 0.0 - 1.0.
-While Qt painters handles HDR data correctly, some older programs may display
+While Qt painters handles HDR data correctly, some older programs may display 
-strange artifacts if they do not use a tone mapping operator (or at least a
+strange artifacts if they do not use a tone mapping operator (or at least a 
 clamp). This is not a plugin issue.
 
 ### Metadata
@@ -129,15 +114,11 @@ plugin ('n/a' means no limit, i.e. the limit depends on the format encoding).
 
 - ANI: n/a
 - AVIF: 32,768 x 32,768 pixels, in any case no larger than 256 megapixels
-- DDS: n/a
 - EXR: 300,000 x 300,000 pixels
-- EPS: n/a
 - HDR: n/a (large image)
 - HEIF: n/a
 - JXL: 262,144 x 262,144 pixels, in any case no larger than 256 megapixels
 - JXR: n/a, in any case no larger than 4 GB
-- KRA: same size as Qt's PNG plugin
-- ORA: same size as Qt's PNG plugin
 - PCX: 65,535 x 65,535 pixels
 - PFM: n/a (large image)
 - PIC: 65,535 x 65,535 pixels
@@ -181,23 +162,10 @@ without using the ICC profile.
 JXR, PSD and SCT plugins natively support 4-channel CMYK images when compiled 
 with Qt 6.8+.
 
-### The DDS plugin
-
-**This plugin can be disabled by setting `KIMAGEFORMATS_DDS` to `OFF` 
-in your cmake options.**
-
-The following defines can be defined in cmake to modify the behavior of the plugin:
-- `DDS_DISABLE_STRIDE_ALIGNMENT`: disable the stride aligment based on DDS pitch: it is known that some writers do not set it correctly.
-
 ### The HEIF plugin
 
-**This plugin is disabled by default. It can be enabled by settings
+**This plugin is disabled by default. It can be enabled with the 
-`KIMAGEFORMATS_HEIF` to `ON` in your cmake options.**
+`KIMAGEFORMATS_HEIF` build option in the cmake file.**
-
-The plugin is disabled due to issues with the heif library on certain
-distributions. In particular, it is necessary that the HEIF library has
-support for HEVC codec. If HEVC codec is not available the plugin
-will compile but will fail the tests.
 
 ### The EXR plugin
 
@@ -205,14 +173,6 @@ The following defines can be defined in cmake to modify the behavior of the plug
 - `EXR_CONVERT_TO_SRGB`: the linear data is converted to sRGB on read to accommodate programs that do not support color profiles.
 - `EXR_DISABLE_XMP_ATTRIBUTE`: disables the stores XMP values in a non-standard attribute named "xmp". Note that Gimp reads the "xmp" attribute and Darktable writes it as well.
 
-### The EPS plugin
-
-The plugin uses `Ghostscript` to convert the raster image. When reading it
-converts the EPS to PPM and uses the Qt PPM plugin to read the image.
-When writing it uses [`QPrinter`](https://doc.qt.io/qt-6/qprinter.html) to
-create a temporary PDF file which is then converted to EPS. Therefore, if
-`Ghostscript` is not installed, the plugin will not work.
-
 ### The HDR plugin
 
 The following defines can be defined in cmake to modify the behavior of the plugin:
@@ -229,8 +189,8 @@ The following defines can be defined in cmake to modify the behavior of the plug
 
 ### The JXR plugin
 
-**This plugin is disabled by default. It can be enabled by settings
+**This plugin is disabled by default. It can be enabled with the 
-`KIMAGEFORMATS_JXR` to `ON` in your cmake options.**
+`KIMAGEFORMATS_JXR` build option in the cmake file.**
 
 The following defines can be defined in cmake to modify the behavior of the plugin:
 - `JXR_DENY_FLOAT_IMAGE`: disables the use of float images and consequently any HDR data will be lost.
@@ -238,24 +198,11 @@ The following defines can be defined in cmake to modify the behavior of the plug
 - `JXR_DISABLE_BGRA_HACK`: Windows displays and opens JXR files correctly out of the box. Unfortunately it doesn't seem to open (P)RGBA @32bpp files as it only wants (P)BGRA32bpp files (a format not supported by Qt). Only for this format an hack is activated to guarantee total compatibility of the plugin with Windows.
 - `JXR_ENABLE_ADVANCED_METADATA`: enable metadata support (e.g. XMP). Some distributions use an incomplete JXR library that does not allow reading metadata, causing compilation errors.
 
-### The KRA plugin
-
-The KRA format is a ZIP archive containing image data. In particular, the
-rendered image in PNG format is saved in the root: the plugin reads this 
-image.
-
-### The ORA plugin
-
-The ORA format is a ZIP archive containing image data. In particular, the
-rendered image in PNG format is saved in the root: the plugin reads this 
-image.
-
 ### The PSD plugin
 
 PSD support has the following limitations:
 - Only images saved by Photoshop using compatibility mode enabled (Photoshop default) can be decoded.
-- Multichannel images are treated as CMYK if they have 2 or more channels.
+- Multichannel images are treated as CMY/CMYK and are only loaded if they have 3 or more channels.
-- Multichannel images are treated as Grayscale if they have 1 channel.
 - Duotone images are treated as grayscale images.
 - Extra channels other than alpha are discarded.
 

autotests/CMakeLists.txt

@@ -76,11 +76,6 @@ kimageformats_read_tests(
     tga
 )
 
-if(KIMAGEFORMATS_DDS)
-    kimageformats_read_tests(dds)
-    kimageformats_write_tests(dds-nodatacheck-lossless)
-endif()
-
 if (KF6Archive_FOUND)
     kimageformats_read_tests(
         kra
@@ -111,12 +106,6 @@ if (LibHeif_FOUND)
             hej2
         )
     endif()
-
-    if (LibHeif_VERSION VERSION_GREATER_EQUAL "1.19.0")
-        kimageformats_read_tests(FUZZ 4
-            avci
-        )
-    endif()
 endif()
 
 if (LibJXL_FOUND AND LibJXLThreads_FOUND)

autotests/read/dds/earth-cubemap.license

@@ -1,2 +0,0 @@
-SPDX-FileCopyrightText: Copyright (c) 2006 - 2010 The Open Toolkit library.
-SPDX-License-Identifier: MIT

autotests/read/pfm/comment_gray_half.phm.json

@@ -1,5 +0,0 @@
-[
-    {
-        "fileName" : "testcard_gray_half.png"
-    }
-]

autotests/readtest.cpp

@@ -263,7 +263,7 @@ int main(int argc, char **argv)
         }
         for (const QFileInfo &fi : lstImgDir) {
             TemplateImage timg(fi);
-            if (timg.isTemplate() || timg.isLicense()) {
+            if (timg.isTemplate()) {
                 continue;
             }
 
@@ -375,66 +375,6 @@ int main(int argc, char **argv)
         }
     }
 
-    // NULL device test
-    for (const QFileInfo &fi : lstImgDir) {
-        TemplateImage timg(fi);
-        if (timg.isTemplate() || timg.isLicense()) {
-            continue;
-        }
-
-        QTextStream(stdout) << "* Run on NULL device\n";
-        QImageReader reader;
-        reader.setFormat(fi.suffix().toLatin1());
-        if (reader.canRead() == true) {
-            QTextStream(stdout) << "FAIL : " << fi.suffix() << ": canRead() returns true\n";
-            ++failed;
-            break;
-        }
-
-        if (!reader.read().isNull()) {
-            QTextStream(stdout) << "FAIL : " << fi.suffix() << ": read() returns a non-NULL image\n";
-            ++failed;
-            break;
-        }
-
-        if (reader.size() != QSize()) {
-            QTextStream(stdout) << "FAIL : " << fi.suffix() << ": size() returns a valid size\n";
-            ++failed;
-            break;
-        }
-
-        if (reader.imageFormat() != QImage::Format_Invalid) {
-            QTextStream(stdout) << "FAIL : " << fi.suffix() << ": size() returns a valid format\n";
-            ++failed;
-            break;
-        }
-
-        // test for crash only
-        reader.textKeys();
-        reader.quality();
-        reader.clipRect();
-        reader.scaledSize();
-        reader.scaledClipRect();
-        reader.backgroundColor();
-        reader.supportsAnimation();
-        reader.transformation();
-        reader.autoTransform();
-        reader.subType();
-        reader.supportedSubTypes();
-        reader.jumpToNextImage();
-        reader.loopCount();
-        reader.imageCount();
-        reader.currentImageNumber();
-        reader.currentImageRect();
-
-        // success
-        QTextStream(stdout) << "PASS : " << fi.suffix() << "\n";
-        ++passed;
-
-        // runs once for each format
-        break;
-    }
-
     QTextStream(stdout) << "Totals: " << passed << " passed, " << skipped << " skipped, " << failed << " failed\n";
     QTextStream(stdout) << "********* "
                         << "Finished basic read tests for " << suffix << " images *********\n";

autotests/templateimage.cpp

@@ -28,11 +28,6 @@ bool TemplateImage::isTemplate() const
     return false;
 }
 
-bool TemplateImage::isLicense() const
-{
-    return !m_fi.suffix().compare(QStringLiteral("license"), Qt::CaseInsensitive);
-}
-
 QFileInfo TemplateImage::compareImage(TestFlags &flags, QString& comment) const
 {
     auto fi = jsonImage(flags, comment);

autotests/templateimage.h

@@ -47,12 +47,6 @@ public:
      */
     bool isTemplate() const;
 
-    /*!
-     * \brief isLicense
-     * \return True if the file suffix is .license
-     */
-    bool isLicense() const;
-
     /*!
      * \brief compareImage
      * \param flags Flags for modifying test behavior (e.g. image format not supported by current Qt version).