mirror/kimageformats
1
0
Fork 0
mirror of https://invent.kde.org/frameworks/kimageformats.git synced 2025-05-28 00:30:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

JXR: set max XMP size to 4MiB

Browse Source
This commit is contained in:
Mirco Miranda 2025-01-15 16:39:26 +01:00 committed by Daniel Novomeský
parent 65a587afad
commit a89367dde6
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/imageformats/jxr.cpp
View File

@ -73,6 +73,13 @@ Q_LOGGING_CATEGORY(LOG_JXRPLUGIN, "kf.imageformats.plugins.jxr", QtWarningMsg)
// #define JXR_ENABLE_ADVANCED_METADATA // #define JXR_ENABLE_ADVANCED_METADATA
#ifndef JXR_MAX_METADATA_SIZE
/*!
* XMP and EXIF maximum size.
*/
#define JXR_MAX_METADATA_SIZE (4 * 1024 * 1024)
#endif
class JXRHandlerPrivate : public QSharedData class JXRHandlerPrivate : public QSharedData
{ {
private: private:
@ -300,7 +307,7 @@ public:
} }
#ifdef JXR_ENABLE_ADVANCED_METADATA #ifdef JXR_ENABLE_ADVANCED_METADATA
quint32 size; quint32 size;
if (!PKImageDecode_GetXMPMetadata_WMP(pDecoder, nullptr, &size) && size) { if (!PKImageDecode_GetXMPMetadata_WMP(pDecoder, nullptr, &size) && size > 0 && size < JXR_MAX_METADATA_SIZE) {
QByteArray ba(size, 0); QByteArray ba(size, 0);
if (!PKImageDecode_GetXMPMetadata_WMP(pDecoder, reinterpret_cast<quint8 *>(ba.data()), &size)) { if (!PKImageDecode_GetXMPMetadata_WMP(pDecoder, reinterpret_cast<quint8 *>(ba.data()), &size)) {
xmp = QString::fromUtf8(ba); xmp = QString::fromUtf8(ba);