mirror/kimageformats
1
0
Fork 0
mirror of https://invent.kde.org/frameworks/kimageformats.git synced 2026-03-13 13:30:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

JP2: fix possible Undefined-shift

Browse Source
This commit is contained in:
Mirco Miranda
2026-03-04 08:15:48 +01:00
parent 5eb09116b0
commit 836e0a53bb
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/imageformats/jp2.cpp
View File

@ -269,10 +269,11 @@ public:
// discriminate between int and float (avoid complicating things by creating classes with template specializations) // discriminate between int and float (avoid complicating things by creating classes with template specializations)
if (std::numeric_limits<T>::is_integer) { if (std::numeric_limits<T>::is_integer) {
auto divisor = 1; auto divisor = 1ull;
if (jc.prec > sizeof(T) * 8) { auto prec = std::min(size_t(jc.prec), sizeof(*jc.data) * 8);
if (prec > sizeof(T) * 8 && prec < 64) {
// convert to the wanted precision (e.g. 16-bit -> 8-bit: divisor = 65535 / 255 = 257) // convert to the wanted precision (e.g. 16-bit -> 8-bit: divisor = 65535 / 255 = 257)
divisor = std::max(1, int(((1ll << jc.prec) - 1) / ((1ll << (sizeof(T) * 8)) - 1))); divisor = std::max(1ull, (((1ull << prec) - 1) / ((1ull << (sizeof(T) * 8)) - 1)));
} }
for (qint32 y = 0, h = img->height(); y < h; ++y) { for (qint32 y = 0, h = img->height(); y < h; ++y) {
auto ptr = reinterpret_cast<T *>(img->scanLine(y)); auto ptr = reinterpret_cast<T *>(img->scanLine(y));