mirror/kimageformats
1
0
Fork 0
mirror of https://invent.kde.org/frameworks/kimageformats.git synced 2025-05-28 00:30:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

test: don't convert image format if possible

Browse Source
This commit is contained in:
Gary Wang 2020-11-09 14:14:21 +08:00
parent 938b8126b5
commit 6cf05cf305
1 changed files with 40 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
autotests/readtest.cpp
View File

@ -36,14 +36,17 @@ static void writeImageData(const char *name, const QString &filename, const QIma
} }
} }
// allow each byte to be different by up to 1, to allow for rounding errors template<class Trait>
static bool fuzzyeq(const QImage &im1, const QImage &im2, uchar fuzziness) static bool fuzzyeq(const QImage &im1, const QImage &im2, uchar fuzziness)
{ {
Q_ASSERT(im1.format() == im2.format());
Q_ASSERT(im1.depth() == 24 || im1.depth() == 32 || im1.depth() == 64);
const int height = im1.height(); const int height = im1.height();
const int width = im1.width(); const int width = im1.width();
for (int i = 0; i < height; ++i) { for (int i = 0; i < height; ++i) {
const uchar *line1 = im1.scanLine(i); const Trait *line1 = reinterpret_cast<const Trait*>(im1.scanLine(i));
const uchar *line2 = im2.scanLine(i); const Trait *line2 = reinterpret_cast<const Trait*>(im2.scanLine(i));
for (int j = 0; j < width; ++j) { for (int j = 0; j < width; ++j) {
if (line1[j] > line2[j]) { if (line1[j] > line2[j]) {
if (line1[j] - line2[j] > fuzziness) if (line1[j] - line2[j] > fuzziness)
@ -57,6 +60,30 @@ static bool fuzzyeq(const QImage &im1, const QImage &im2, uchar fuzziness)
return true; return true;
} }
// allow each byte to be different by up to 1, to allow for rounding errors
static bool fuzzyeq(const QImage &im1, const QImage &im2, uchar fuzziness)
{
return (im1.depth() == 64) ? fuzzyeq<quint16>(im1, im2, fuzziness)
: fuzzyeq<quint8>(im1, im2, fuzziness);
}
// Returns the original format if we support, or returns
// format which we preferred to use for `fuzzyeq()`.
// We do only support formats with 8-bits/16-bits pre pixel.
// If that changed, don't forget to update `fuzzyeq()` too
static QImage::Format preferredFormat(QImage::Format fmt)
{
switch (fmt) {
case QImage::Format_RGB32:
case QImage::Format_ARGB32:
case QImage::Format_RGBX64:
case QImage::Format_RGBA64:
return fmt;
default:
return QImage::Format_ARGB32;
}
}
int main(int argc, char ** argv) int main(int argc, char ** argv)
{ {
QCoreApplication app(argc, argv); QCoreApplication app(argc, argv);
@ -168,19 +195,23 @@ int main(int argc, char ** argv)
<< expImage.height() << "\n"; << expImage.height() << "\n";
++failed; ++failed;
} else { } else {
if (inputImage.format() != QImage::Format_ARGB32) { QImage::Format inputFormat = preferredFormat(inputImage.format());
QImage::Format expFormat = preferredFormat(expImage.format());
QImage::Format cmpFormat = inputFormat == expFormat ? inputFormat : QImage::Format_ARGB32;
if (inputImage.format() != cmpFormat) {
QTextStream(stdout) << "INFO : " << fi.fileName() QTextStream(stdout) << "INFO : " << fi.fileName()
<< ": converting " << fi.fileName() << ": converting " << fi.fileName()
<< " from " << formatToString(inputImage.format()) << " from " << formatToString(inputImage.format())
<< " to ARGB32\n"; << " to " << formatToString(cmpFormat) << '\n';
inputImage = inputImage.convertToFormat(QImage::Format_ARGB32); inputImage = inputImage.convertToFormat(cmpFormat);
} }
if (expImage.format() != QImage::Format_ARGB32) { if (expImage.format() != cmpFormat) {
QTextStream(stdout) << "INFO : " << fi.fileName() QTextStream(stdout) << "INFO : " << fi.fileName()
<< ": converting " << expfilename << ": converting " << expfilename
<< " from " << formatToString(expImage.format()) << " from " << formatToString(expImage.format())
<< " to ARGB32\n"; << " to " << formatToString(cmpFormat) << '\n';
expImage = expImage.convertToFormat(QImage::Format_ARGB32); expImage = expImage.convertToFormat(cmpFormat);
} }
if (fuzzyeq(inputImage, expImage, fuzziness)) { if (fuzzyeq(inputImage, expImage, fuzziness)) {
QTextStream(stdout) << "PASS : " << fi.fileName() << "\n"; QTextStream(stdout) << "PASS : " << fi.fileName() << "\n";