mirror/kimageformats
1
0
Fork 0
mirror of https://invent.kde.org/frameworks/kimageformats.git synced 2025-05-28 00:30:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

pcx: fix crash on invalid files

Browse Source 
Added new PCX testfile for readtest.
This commit is contained in:
Daniel Novomeský 2024-07-18 20:10:55 +02:00 committed by Albert Astals Cid
parent a497ab789b
commit 638fdfcbdd
3 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
autotests/read/pcx/16color.pcx Normal file
View File

Binary file not shown.

BIN
autotests/read/pcx/16color.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 4.3 KiB

5
src/imageformats/pcx.cpp
View File

@ -308,6 +308,11 @@ static bool readImage4(QImage &img, QDataStream &s, const PCXHEADER &header)
return false; return false;
} }
if (header.BytesPerLine < (header.width() / 8)) {
qWarning() << "PCX image has invalid BytesPerLine value";
return false;
}
for (int y = 0; y < header.height(); ++y) { for (int y = 0; y < header.height(); ++y) {
if (s.atEnd()) { if (s.atEnd()) {
return false; return false;