From 348ddce98725bde22e2df771a107dbae79f033ab Mon Sep 17 00:00:00 2001 From: Mirco Miranda Date: Mon, 23 Dec 2024 22:05:05 +0000 Subject: [PATCH] XCF: Fix OSS Fuzz issue 42527849 Fixes integer overflow when the value is -INT_MAX-1 --- src/imageformats/xcf.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/imageformats/xcf.cpp b/src/imageformats/xcf.cpp index 06a2fef..b05ad4e 100644 --- a/src/imageformats/xcf.cpp +++ b/src/imageformats/xcf.cpp @@ -1305,21 +1305,22 @@ bool XCFImageFormat::loadLayerProperties(QDataStream &xcf_io, Layer &layer) case PROP_COMPOSITE_SPACE: property >> layer.compositeSpace; if (layer.compositeSpace < 0) { - layer.compositeSpace = GimpColorSpace(-layer.compositeSpace); + layer.compositeSpace = GimpColorSpace(layer.compositeSpace == std::numeric_limits::lowest() ? 0 : -layer.compositeSpace); } break; case PROP_COMPOSITE_MODE: property >> layer.compositeMode; if (layer.compositeMode < 0) { - layer.compositeMode = XCFImageFormat::GimpCompositeMode(-layer.compositeMode); + layer.compositeMode = + XCFImageFormat::GimpCompositeMode(layer.compositeMode == std::numeric_limits::lowest() ? 0 : -layer.compositeMode); } break; case PROP_BLEND_SPACE: property >> layer.blendSpace; - if (layer.blendSpace) { - layer.blendSpace = GimpColorSpace(-layer.blendSpace); + if (layer.blendSpace < 0) { + layer.blendSpace = GimpColorSpace(layer.blendSpace == std::numeric_limits::lowest() ? 0 : -layer.blendSpace); } break;