mirror/kimageformats
1
0
Fork 0
mirror of https://invent.kde.org/frameworks/kimageformats.git synced 2025-05-28 00:30:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

DDS: enable plugin by default

Browse Source 
- Enabled the plugin as OSS Fuzz did not find anything yet
- Modified README by adding more info about contributing, DDS plugin and some clarifications

Solves CCBUG: 380956 CCBUG: 389900
This commit is contained in:
Mirco Miranda 2024-12-24 08:59:32 +00:00
parent 894524f7e4
commit 0b2c6d725d
2 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CMakeLists.txt
View File

@ -62,8 +62,7 @@ set_package_properties(libavif PROPERTIES
PURPOSE "Required for the QImage plugin for AVIF images" PURPOSE "Required for the QImage plugin for AVIF images"
) )
# DDS plugin disabled by default due to security issues option(KIMAGEFORMATS_DDS "Enable plugin for DDS format" ON)
option(KIMAGEFORMATS_DDS "Enable plugin for DDS format" OFF)
option(KIMAGEFORMATS_HEIF "Enable plugin for HEIF format" OFF) option(KIMAGEFORMATS_HEIF "Enable plugin for HEIF format" OFF)
if(KIMAGEFORMATS_HEIF) if(KIMAGEFORMATS_HEIF)

22
README.md
View File

@ -50,6 +50,10 @@ of Qt is the license. As such, if you write an imageformat plugin and
you are willing to sign the Qt Project contributor agreement, it may be you are willing to sign the Qt Project contributor agreement, it may be
better to submit the plugin directly to the Qt Project. better to submit the plugin directly to the Qt Project.
To be accepted, contributions must:
- Contain the test images needed to verify that the changes work correctly
- Pass the tests successfully
## Duplicated Plugins ## Duplicated Plugins
### The TGA plugin ### The TGA plugin
@ -66,8 +70,7 @@ removed.
### The DDS plugin ### The DDS plugin
The DDS plugin is a fork of Qt 5.6 with bug fixes and improvements. It The DDS plugin is a fork from Qt 5.6 with bug fixes and improvements.
will be activated once the security issues are resolved.
## License ## License
@ -174,16 +177,19 @@ with Qt 6.8+.
### The DDS plugin ### The DDS plugin
**This plugin is disabled by default. It can be enabled with the **This plugin can be disabled by setting `KIMAGEFORMATS_DDS` to `OFF`
`KIMAGEFORMATS_DDS` build option in the cmake file.** in your cmake options.**
The following defines can be defined in cmake to modify the behavior of the plugin: The following defines can be defined in cmake to modify the behavior of the plugin:
- `DDS_DISABLE_STRIDE_ALIGNMENT`: disable the stride aligment based on DDS pitch: it is known that some writers do not set it correctly. - `DDS_DISABLE_STRIDE_ALIGNMENT`: disable the stride aligment based on DDS pitch: it is known that some writers do not set it correctly.
### The HEIF plugin ### The HEIF plugin
**This plugin is disabled by default. It can be enabled with the **This plugin is disabled by default. It can be enabled by settings
`KIMAGEFORMATS_HEIF` build option in the cmake file.** `KIMAGEFORMATS_HEIF` to `ON` in your cmake options.**
The plugin is disabled due to issues with the heif library on certain
distributions. If enabled, tests may fail.
### The EXR plugin ### The EXR plugin
@ -207,8 +213,8 @@ The following defines can be defined in cmake to modify the behavior of the plug
### The JXR plugin ### The JXR plugin
**This plugin is disabled by default. It can be enabled with the **This plugin is disabled by default. It can be enabled by settings
`KIMAGEFORMATS_JXR` build option in the cmake file.** `KIMAGEFORMATS_JXR` to `ON` in your cmake options.**
The following defines can be defined in cmake to modify the behavior of the plugin: The following defines can be defined in cmake to modify the behavior of the plugin:
- `JXR_DENY_FLOAT_IMAGE`: disables the use of float images and consequently any HDR data will be lost. - `JXR_DENY_FLOAT_IMAGE`: disables the use of float images and consequently any HDR data will be lost.