refactor: Extract performance logging to separate class (#124)

This should not be responsibility of LLMClientInterface. Extracting this
class also adds flexibility to silence logging output in tests.
This commit is contained in:
Povilas Kanapickas
2025-03-10 18:10:01 +02:00
committed by GitHub
parent 7dd8b3d085
commit ed59be4199
8 changed files with 180 additions and 32 deletions

View File

@ -1,6 +1,9 @@
add_library(QodeAssistLogger STATIC
EmptyRequestPerformanceLogger.hpp
IRequestPerformanceLogger.hpp
Logger.cpp
Logger.hpp
RequestPerformanceLogger.hpp RequestPerformanceLogger.cpp
)
target_link_libraries(QodeAssistLogger

View File

@ -0,0 +1,32 @@
/*
* Copyright (C) 2025 Povilas Kanapickas <povilas@radix.lt>
*
* This file is part of QodeAssist.
*
* QodeAssist is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* QodeAssist is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with QodeAssist. If not, see <https://www.gnu.org/licenses/>.
*/
#include "IRequestPerformanceLogger.hpp"
namespace QodeAssist {
class EmptyRequestPerformanceLogger : public IRequestPerformanceLogger
{
public:
void startTimeMeasurement(const QString &requestId) override {}
void endTimeMeasurement(const QString &requestId) override {}
void logPerformance(const QString &requestId, qint64 elapsedMs) override {}
};
} // namespace QodeAssist

View File

@ -0,0 +1,36 @@
/*
* Copyright (C) 2025 Povilas Kanapickas <povilas@radix.lt>
*
* This file is part of QodeAssist.
*
* QodeAssist is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* QodeAssist is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with QodeAssist. If not, see <https://www.gnu.org/licenses/>.
*/
#pragma once
#include <QString>
namespace QodeAssist {
class IRequestPerformanceLogger
{
public:
virtual ~IRequestPerformanceLogger() = default;
virtual void startTimeMeasurement(const QString &requestId) = 0;
virtual void endTimeMeasurement(const QString &requestId) = 0;
virtual void logPerformance(const QString &requestId, qint64 elapsedMs) = 0;
};
} // namespace QodeAssist

View File

@ -0,0 +1,55 @@
/*
* Copyright (C) 2025 Povilas Kanapickas <povilas@radix.lt>
*
* This file is part of QodeAssist.
*
* QodeAssist is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* QodeAssist is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with QodeAssist. If not, see <https://www.gnu.org/licenses/>.
*/
#include "RequestPerformanceLogger.hpp"
#include "Logger.hpp"
namespace QodeAssist {
void RequestPerformanceLogger::startTimeMeasurement(const QString &requestId)
{
m_requestStartTimes[requestId] = QDateTime::currentMSecsSinceEpoch();
}
void RequestPerformanceLogger::endTimeMeasurement(const QString &requestId)
{
if (!m_requestStartTimes.contains(requestId)) {
return;
}
qint64 startTime = m_requestStartTimes[requestId];
qint64 endTime = QDateTime::currentMSecsSinceEpoch();
qint64 totalTime = endTime - startTime;
logPerformance(requestId, totalTime);
m_requestStartTimes.remove(requestId);
}
void RequestPerformanceLogger::logPerformance(const QString &requestId, qint64 elapsedMs)
{
LOG_MESSAGE(
QString("Performance: %1 total completion time took %2 ms").arg(requestId).arg(elapsedMs));
}
void RequestPerformanceLogger::logPerformance(
const QString &requestId, const QString &operation, qint64 elapsedMs)
{
LOG_MESSAGE(QString("Performance: %1 %2 took %3 ms").arg(requestId, operation).arg(elapsedMs));
}
} // namespace QodeAssist

View File

@ -0,0 +1,41 @@
/*
* Copyright (C) 2025 Povilas Kanapickas <povilas@radix.lt>
*
* This file is part of QodeAssist.
*
* QodeAssist is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* QodeAssist is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with QodeAssist. If not, see <https://www.gnu.org/licenses/>.
*/
#include "IRequestPerformanceLogger.hpp"
#include <QDateTime>
#include <QMap>
namespace QodeAssist {
class RequestPerformanceLogger : public IRequestPerformanceLogger
{
public:
RequestPerformanceLogger() = default;
~RequestPerformanceLogger() override = default;
void startTimeMeasurement(const QString &requestId) override;
void endTimeMeasurement(const QString &requestId) override;
void logPerformance(const QString &requestId, qint64 elapsedMs) override;
void logPerformance(const QString &requestId, const QString &operation, qint64 elapsedMs);
private:
QMap<QString, qint64> m_requestStartTimes;
};
} // namespace QodeAssist