refactor: Uses single QML engine for all QML code (#323)

* refactor: Uses single QML engine for all QML code

* fix: Adds missing `QPointer` include

* Parents QML engine instance to plugin instance.

---------

Co-authored-by: Ivan Lebedev <ilebedev@flightpath3d.com>
Co-authored-by: Ivan Lebedev <ilebedev1988@gmail.com>

ChatView/ChatView.cpp

@@ -3,6 +3,7 @@
 
 #include "ChatView.hpp"
 
+#include <QQmlComponent>
 #include <QQmlContext>
 #include <QQmlEngine>
 #include <QSettings>
@@ -19,12 +20,21 @@ constexpr Qt::WindowFlags baseFlags = Qt::Window | Qt::WindowTitleHint | Qt::Win
 
 namespace QodeAssist::Chat {
 
-ChatView::ChatView()
+ChatView::ChatView(QQmlEngine* engine)
-    : m_isPin(false)
+    : QQuickView{engine, nullptr}
+    , m_isPin(false)
 {
     setTitle("QodeAssist Chat");
-    engine()->rootContext()->setContextProperty("_chatview", this);
+    /// @note setup quick view content
-    setSource(QUrl("qrc:/qt/qml/ChatView/qml/RootItem.qml"));
+    {
+        auto context = new QQmlContext{engine, this};
+        context->setContextProperty("_chatview", this);
+
+        auto component = new QQmlComponent{engine, QUrl{"qrc:/qt/qml/ChatView/qml/RootItem.qml"}, this};
+        auto rootItem = component->create(context);
+
+        setContent(component->url(), component, rootItem);
+    }
     setResizeMode(QQuickView::SizeRootObjectToView);
     setMinimumSize({400, 300});
     setFlags(baseFlags);

ChatView/ChatView.hpp

@@ -13,7 +13,7 @@ class ChatView : public QQuickView
     Q_OBJECT
     Q_PROPERTY(bool isPin READ isPin WRITE setIsPin NOTIFY isPinChanged FINAL)
 public:
-    ChatView();
+    ChatView(QQmlEngine* engine);
 
     bool isPin() const;
     void setIsPin(bool newIsPin);

ChatView/ChatWidget.cpp

@@ -8,10 +8,17 @@
 
 namespace QodeAssist::Chat {
 
-ChatWidget::ChatWidget(QWidget *parent)
+ChatWidget::ChatWidget(QQmlEngine* engine, QWidget *parent)
-    : QQuickWidget(parent)
+    : QQuickWidget{engine, parent}
 {
-    setSource(QUrl("qrc:/qt/qml/ChatView/qml/RootItem.qml"));
+    /// @note setup quick view content
+    {
+        auto context = new QQmlContext{engine, this};
+        auto component = new QQmlComponent{engine, QUrl{"qrc:/qt/qml/ChatView/qml/RootItem.qml"}, this};
+        auto rootItem = component->create(context);
+
+        setContent(component->url(), component, rootItem);
+    }
     setResizeMode(QQuickWidget::SizeRootObjectToView);
 }
 

ChatView/ChatWidget.hpp

@@ -12,7 +12,7 @@ class ChatWidget : public QQuickWidget
     Q_OBJECT
 
 public:
-    explicit ChatWidget(QWidget *parent = nullptr);
+    explicit ChatWidget(QQmlEngine* engine, QWidget *parent = nullptr);
     ~ChatWidget() = default;
 
     Q_INVOKABLE void clear();

chat/ChatOutputPane.cpp

@@ -7,9 +7,9 @@
 
 namespace QodeAssist::Chat {
 
-ChatOutputPane::ChatOutputPane(QObject *parent)
+ChatOutputPane::ChatOutputPane(QQmlEngine* engine, QObject *parent)
     : Core::IOutputPane(parent)
-    , m_chatWidget(new ChatWidget)
+    , m_chatWidget{new ChatWidget{engine}}
 {
     setId("QodeAssistChat");
     setDisplayName(Tr::tr("QodeAssist Chat"));

chat/ChatOutputPane.h

@@ -13,7 +13,7 @@ class ChatOutputPane : public Core::IOutputPane
     Q_OBJECT
 
 public:
-    explicit ChatOutputPane(QObject *parent = nullptr);
+    explicit ChatOutputPane(QQmlEngine* engine, QObject *parent = nullptr);
     ~ChatOutputPane() override;
 
     QWidget *outputWidget(QWidget *parent) override;

chat/NavigationPanel.cpp

@@ -7,7 +7,8 @@
 
 namespace QodeAssist::Chat {
 
-NavigationPanel::NavigationPanel()
+NavigationPanel::NavigationPanel(QQmlEngine* engine)
+    : m_engine{engine}
 {
     setDisplayName(tr("QodeAssist Chat"));
     setPriority(500);
@@ -19,10 +20,7 @@ NavigationPanel::~NavigationPanel() {}
 
 Core::NavigationView NavigationPanel::createWidget()
 {
-    Core::NavigationView view;
+    return {.widget = new ChatWidget{m_engine}};
-    view.widget = new ChatWidget;
-
-    return view;
 }
 
 } // namespace QodeAssist::Chat

chat/NavigationPanel.hpp

@@ -5,6 +5,9 @@
 
 #include <coreplugin/inavigationwidgetfactory.h>
 #include <QObject>
+#include <QPointer>
+
+class QQmlEngine;
 
 namespace QodeAssist::Chat {
 
@@ -12,10 +15,13 @@ class NavigationPanel : public Core::INavigationWidgetFactory
 {
     Q_OBJECT
 public:
-    explicit NavigationPanel();
+    explicit NavigationPanel(QQmlEngine* engine);
     ~NavigationPanel();
 
     Core::NavigationView createWidget() override;
+
+private:
+    QPointer<QQmlEngine> m_engine;
 };
 
 } // namespace QodeAssist::Chat

qodeassist.cpp

@@ -151,11 +151,13 @@ public:
             UpdateDialog::checkForUpdatesAndShow(Core::ICore::mainWindow());
         });
 
+        m_engine = new QQmlEngine{this};
+
         if (Settings::chatAssistantSettings().enableChatInBottomToolBar()) {
-            m_chatOutputPane = new Chat::ChatOutputPane(this);
+            m_chatOutputPane = new Chat::ChatOutputPane{m_engine};
         }
         if (Settings::chatAssistantSettings().enableChatInNavigationPanel()) {
-            m_navigationPanel = new Chat::NavigationPanel();
+            m_navigationPanel = new Chat::NavigationPanel{m_engine};
         }
 
         Settings::setupProjectPanel();
@@ -204,7 +206,7 @@ public:
         showChatViewAction.setIcon(QCODEASSIST_CHAT_ICON.icon());
         showChatViewAction.addOnTriggered(this, [this] {
             if (!m_chatView) {
-                m_chatView.reset(new Chat::ChatView());
+                m_chatView.reset(new Chat::ChatView{m_engine});
             }
 
             if (!m_chatView->isVisible()) {
@@ -302,6 +304,7 @@ private:
     QString m_lastRefactorInstructions;
     QScopedPointer<Chat::ChatView> m_chatView;
     QPointer<Mcp::McpServerManager> m_mcpServerManager;
+    QPointer<QQmlEngine> m_engine;
 };
 
 } // namespace QodeAssist::Internal