mirror/QodeAssist
1
0
Fork 0
mirror of https://github.com/Palm1r/QodeAssist.git synced 2025-05-28 03:10:28 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: Resolve thread-related QNetworkAccessManager issue (#140)

Browse Source 
Fixes "QObject: Cannot create children for a parent that is in a different thread" error by creating QNetworkAccessManager in the same thread where it's used, ensuring proper thread affinity for network operations.
This commit is contained in:
Petr Mironychev 2025-03-16 09:47:04 +01:00 committed by GitHub
parent 91a6a88130
commit 8419577ae5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llmcore/RequestHandler.cpp
View File

@ -27,7 +27,6 @@ namespace QodeAssist::LLMCore {
RequestHandler::RequestHandler(QObject *parent) RequestHandler::RequestHandler(QObject *parent)
: RequestHandlerBase(parent) : RequestHandlerBase(parent)
, m_manager(new QNetworkAccessManager(this))
{} {}
void RequestHandler::sendLLMRequest(const LLMConfig &config, const QJsonObject &request) void RequestHandler::sendLLMRequest(const LLMConfig &config, const QJsonObject &request)
@ -38,11 +37,12 @@ void RequestHandler::sendLLMRequest(const LLMConfig &config, const QJsonObject &
QString::fromUtf8( QString::fromUtf8(
QJsonDocument(config.providerRequest).toJson(QJsonDocument::Indented)))); QJsonDocument(config.providerRequest).toJson(QJsonDocument::Indented))));
QNetworkAccessManager *manager = new QNetworkAccessManager();
QNetworkRequest networkRequest(config.url); QNetworkRequest networkRequest(config.url);
config.provider->prepareNetworkRequest(networkRequest); config.provider->prepareNetworkRequest(networkRequest);
QNetworkReply *reply QNetworkReply *reply
= m_manager->post(networkRequest, QJsonDocument(config.providerRequest).toJson()); = manager->post(networkRequest, QJsonDocument(config.providerRequest).toJson());
if (!reply) { if (!reply) {
LOG_MESSAGE("Error: Failed to create network reply"); LOG_MESSAGE("Error: Failed to create network reply");
return; return;
@ -54,6 +54,7 @@ void RequestHandler::sendLLMRequest(const LLMConfig &config, const QJsonObject &
connect(reply, &QNetworkReply::readyRead, this, [this, reply, request, config]() { connect(reply, &QNetworkReply::readyRead, this, [this, reply, request, config]() {
handleLLMResponse(reply, request, config); handleLLMResponse(reply, request, config);
}); });
connect(reply, &QNetworkReply::finished, this, [manager]() { manager->deleteLater(); });
connect(reply, &QNetworkReply::finished, this, [this, reply, requestId]() { connect(reply, &QNetworkReply::finished, this, [this, reply, requestId]() {
reply->deleteLater(); reply->deleteLater();

1
llmcore/RequestHandler.hpp
View File

@ -40,7 +40,6 @@ public:
void handleLLMResponse(QNetworkReply *reply, const QJsonObject &request, const LLMConfig &config); void handleLLMResponse(QNetworkReply *reply, const QJsonObject &request, const LLMConfig &config);
private: private:
QNetworkAccessManager *m_manager;
QMap<QString, QNetworkReply *> m_activeRequests; QMap<QString, QNetworkReply *> m_activeRequests;
QMap<QNetworkReply *, QString> m_accumulatedResponses; QMap<QNetworkReply *, QString> m_accumulatedResponses;