feat: Add skills feature for tool and chat calling (#351)

This commit is contained in:
Petr Mironychev
2026-05-19 09:46:50 +02:00
committed by GitHub
parent a3ad314cd4
commit 7483c78777
41 changed files with 1379 additions and 30 deletions

84
tools/SkillTool.cpp Normal file
View File

@@ -0,0 +1,84 @@
// Copyright (C) 2026 Petr Mironychev
// SPDX-License-Identifier: GPL-3.0-or-later
#include "SkillTool.hpp"
#include <LLMQore/ToolExceptions.hpp>
#include <optional>
#include <QJsonArray>
#include <QtConcurrent>
#include "sources/skills/AgentSkill.hpp"
#include "sources/skills/SkillsManager.hpp"
namespace QodeAssist::Tools {
SkillTool::SkillTool(Skills::SkillsManager *skillsManager, QObject *parent)
: BaseTool(parent)
, m_skillsManager(skillsManager)
{}
QString SkillTool::id() const
{
return "load_skill";
}
QString SkillTool::displayName() const
{
return "Loading skill";
}
QString SkillTool::description() const
{
return "Load the full instructions of a skill by name. The Available Skills catalog in "
"the system prompt lists each skill's name and a short description. When a request "
"matches a skill, call this tool with that skill's name to load its complete "
"instructions, then follow them.";
}
QJsonObject SkillTool::parametersSchema() const
{
QJsonObject properties;
properties["name"] = QJsonObject{
{"type", "string"},
{"description",
"Exact name of the skill to load, as shown in the Available Skills catalog."}};
QJsonObject definition;
definition["type"] = "object";
definition["properties"] = properties;
definition["required"] = QJsonArray{"name"};
return definition;
}
QFuture<LLMQore::ToolResult> SkillTool::executeAsync(const QJsonObject &input)
{
const QString name = input["name"].toString().trimmed();
const std::optional<Skills::AgentSkill> found
= m_skillsManager ? m_skillsManager->findByName(name) : std::nullopt;
return QtConcurrent::run([name, found]() -> LLMQore::ToolResult {
if (name.isEmpty()) {
throw LLMQore::ToolInvalidArgument(
"'name' parameter is required and cannot be empty");
}
if (!found) {
throw LLMQore::ToolRuntimeError(
QString("Unknown skill: '%1'. Use a skill name from the Available Skills "
"catalog in the system prompt.")
.arg(name));
}
if (found->body.isEmpty()) {
throw LLMQore::ToolRuntimeError(
QString("Skill '%1' has no instructions.").arg(found->name));
}
return LLMQore::ToolResult::text(
QString("Skill: %1\n\n%2").arg(found->name, found->body));
});
}
} // namespace QodeAssist::Tools

35
tools/SkillTool.hpp Normal file
View File

@@ -0,0 +1,35 @@
// Copyright (C) 2026 Petr Mironychev
// SPDX-License-Identifier: GPL-3.0-or-later
#pragma once
#include <LLMQore/BaseTool.hpp>
#include <QFuture>
#include <QJsonObject>
#include <QObject>
#include <QPointer>
namespace QodeAssist::Skills {
class SkillsManager;
}
namespace QodeAssist::Tools {
class SkillTool : public ::LLMQore::BaseTool
{
Q_OBJECT
public:
explicit SkillTool(Skills::SkillsManager *skillsManager, QObject *parent = nullptr);
QString id() const override;
QString displayName() const override;
QString description() const override;
QJsonObject parametersSchema() const override;
QFuture<LLMQore::ToolResult> executeAsync(const QJsonObject &input) override;
private:
QPointer<Skills::SkillsManager> m_skillsManager;
};
} // namespace QodeAssist::Tools

View File

@@ -18,6 +18,7 @@
#include "ProjectSearchTool.hpp"
#include "ReadFileTool.hpp"
#include "ReadOriginalHistoryTool.hpp"
#include "SkillTool.hpp"
#include "TodoTool.hpp"
namespace QodeAssist::Tools {
@@ -66,4 +67,26 @@ void registerQodeAssistTools(::LLMQore::ToolsManager *manager)
manager, s.enableReadOriginalHistoryTool, "read_original_history");
}
void registerSkillTool(
::LLMQore::ToolsManager *manager, Skills::SkillsManager *skillsManager)
{
Utils::BoolAspect &aspect = Settings::toolsSettings().enableSkillTool;
const QString toolId = QStringLiteral("load_skill");
auto sync = [manager, toolId, &aspect, skillsManager]() {
const bool wanted = aspect.volatileValue();
const bool present = manager->tool(toolId) != nullptr;
if (wanted && !present) {
manager->addTool(new SkillTool(skillsManager, manager));
} else if (!wanted && present) {
manager->removeTool(toolId);
}
};
sync();
QObject::connect(&aspect, &Utils::BoolAspect::volatileValueChanged, manager, sync);
QObject::connect(&aspect, &Utils::BaseAspect::changed, manager, sync);
}
} // namespace QodeAssist::Tools

View File

@@ -7,8 +7,15 @@ namespace LLMQore {
class ToolsManager;
}
namespace QodeAssist::Skills {
class SkillsManager;
}
namespace QodeAssist::Tools {
void registerQodeAssistTools(::LLMQore::ToolsManager *manager);
void registerSkillTool(
::LLMQore::ToolsManager *manager, Skills::SkillsManager *skillsManager);
} // namespace QodeAssist::Tools