From 6a0198ae9b94cdd1b14011beb574722bd881e084 Mon Sep 17 00:00:00 2001 From: Petr Mironychev <9195189+Palm1r@users.noreply.github.com> Date: Sun, 20 Jul 2025 12:52:02 +0200 Subject: [PATCH] refactor: Moved execute function to protected --- TaskFlow/core/BaseTask.cpp | 26 ++++++++++++++------------ TaskFlow/core/BaseTask.hpp | 4 +++- 2 files changed, 17 insertions(+), 13 deletions(-) diff --git a/TaskFlow/core/BaseTask.cpp b/TaskFlow/core/BaseTask.cpp index 9b5454f..848162e 100644 --- a/TaskFlow/core/BaseTask.cpp +++ b/TaskFlow/core/BaseTask.cpp @@ -64,22 +64,24 @@ void BaseTask::addOutputPort(const QString &name) TaskPort *BaseTask::inputPort(const QString &name) const { - for (TaskPort *port : m_inputs) { - if (port->name() == name) { - return port; - } - } - return nullptr; + QMutexLocker locker(&m_tasksMutex); + + auto it = std::find_if(m_inputs.begin(), m_inputs.end(), [&name](const TaskPort *port) { + return port->name() == name; + }); + + return (it != m_inputs.end()) ? *it : nullptr; } TaskPort *BaseTask::outputPort(const QString &name) const { - for (TaskPort *port : m_outputs) { - if (port->name() == name) { - return port; - } - } - return nullptr; + QMutexLocker locker(&m_tasksMutex); + + auto it = std::find_if(m_outputs.begin(), m_outputs.end(), [&name](const TaskPort *port) { + return port->name() == name; + }); + + return (it != m_outputs.end()) ? *it : nullptr; } QList BaseTask::getInputPorts() const diff --git a/TaskFlow/core/BaseTask.hpp b/TaskFlow/core/BaseTask.hpp index 5a5c3e3..5a81bfd 100644 --- a/TaskFlow/core/BaseTask.hpp +++ b/TaskFlow/core/BaseTask.hpp @@ -51,11 +51,13 @@ public: QList getInputPorts() const; QList getOutputPorts() const; - QFuture executeAsync(); virtual TaskState execute() = 0; static QString taskStateAsString(TaskState state); +protected: + QFuture executeAsync(); + private: QString m_taskId; QList m_inputs;