mirror/QodeAssist
1
0
Fork 0
mirror of https://github.com/Palm1r/QodeAssist.git synced 2025-07-17 20:44:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Don't use global state in ContextManager::isSpecifyCompletion (#112)

Browse Source 
Using global state makes testing things way harder.
This commit is contained in:
Povilas Kanapickas
2025-03-08 11:38:52 +02:00
committed by GitHub
parent 3aae923d43
commit 44b3b0cc0c
3 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
context/ContextManager.cpp
View File

@ -70,7 +70,7 @@ ContentFile ContextManager::createContentFile(const QString &filePath) const
return contentFile;
}
ProgrammingLanguage ContextManager::getDocumentLanguage(const QJsonObject &request) const
ProgrammingLanguage ContextManager::getDocumentLanguage(const QJsonObject &request)
{
QJsonObject params = request["params"].toObject();
QJsonObject doc = params["doc"].toObject();
@ -88,10 +88,9 @@ ProgrammingLanguage ContextManager::getDocumentLanguage(const QJsonObject &reque
return Context::ProgrammingLanguageUtils::fromMimeType(textDocument->mimeType());
}
bool ContextManager::isSpecifyCompletion(const QJsonObject &request)
bool ContextManager::isSpecifyCompletion(
const QJsonObject &request, const Settings::GeneralSettings &generalSettings)
{
auto &generalSettings = Settings::generalSettings();
Context::ProgrammingLanguage documentLanguage = getDocumentLanguage(request);
Context::ProgrammingLanguage preset1Language = Context::ProgrammingLanguageUtils::fromString(
generalSettings.preset1Language.displayForIndex(generalSettings.preset1Language()));