mirror/QodeAssist
1
0
Fork 0
mirror of https://github.com/Palm1r/QodeAssist.git synced 2025-05-28 03:10:28 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Pass LLMClientInterface to QodeAssistClient (#122)

Browse Source 
Contructing LLMClientInterface in constructor of QodeAssistClient when
initializing base class severely limits what can be done. In particular,
no members can be referred to, because nothing of the class instance
itself has been initialized at that point of time.
This commit is contained in:
Povilas Kanapickas 2025-03-10 17:56:27 +02:00 committed by GitHub
parent 6b86637dcb
commit 3839d6896c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
QodeAssistClient.cpp
View File

@ -44,13 +44,8 @@ using namespace Core;
namespace QodeAssist {
QodeAssistClient::QodeAssistClient(
LLMCore::IProviderRegistry &providerRegistry, LLMCore::IPromptProvider *promptProvider)
: LanguageClient::Client(new LLMClientInterface(
Settings::generalSettings(),
Settings::codeCompletionSettings(),
providerRegistry,
promptProvider))
QodeAssistClient::QodeAssistClient(LLMClientInterface *clientInterface)
: LanguageClient::Client(clientInterface)
, m_recentCharCount(0)
{
setName("Qode Assist");

4
QodeAssistClient.hpp
View File

@ -24,6 +24,7 @@
#pragma once
#include "LLMClientInterface.hpp"
#include "LSPCompletion.hpp"
#include <languageclient/client.h>
#include <llmcore/IPromptProvider.hpp>
@ -34,8 +35,7 @@ namespace QodeAssist {
class QodeAssistClient : public LanguageClient::Client
{
public:
explicit QodeAssistClient(
LLMCore::IProviderRegistry &providerRegistry, LLMCore::IPromptProvider *promptProvider);
explicit QodeAssistClient(LLMClientInterface *clientInterface);
~QodeAssistClient() override;
void openDocument(TextEditor::TextDocument *document) override;

7
qodeassist.cpp
View File

@ -138,8 +138,11 @@ public:
void restartClient()
{
LanguageClient::LanguageClientManager::shutdownClient(m_qodeAssistClient);
m_qodeAssistClient
= new QodeAssistClient(LLMCore::ProvidersManager::instance(), &m_promptProvider);
m_qodeAssistClient = new QodeAssistClient(new LLMClientInterface(
Settings::generalSettings(),
Settings::codeCompletionSettings(),
LLMCore::ProvidersManager::instance(),
&m_promptProvider));
}
bool delayedInitialize() final