mirror/QodeAssist
1
0
Fork 0
mirror of https://github.com/Palm1r/QodeAssist.git synced 2026-07-10 21:31:03 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: Found and fix review mistakes

Browse Source
This commit is contained in:
Petr Mironychev
2026-07-02 22:26:07 +02:00
parent c070d65366
commit 35bbaa1af0
139 changed files with 2032 additions and 1573 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
sources/agents/ContextRenderer.cpp
View File

@@ -61,11 +61,18 @@ QString expandAndResolvePath(const QString &raw, const Bindings &b)
return p;
}
bool hasUnresolvedVars(const QString &p)
{
return p.contains(QStringLiteral("${PROJECT_DIR}"))
|| p.contains(QStringLiteral("${CONFIG_DIR}"));
}
[[noreturn]] void throwOutsideRoots(const char *fn, const QString &path)
{
throw std::runtime_error(
QStringLiteral("%1: path is outside the allowed read roots "
"(the project directory, ~/qodeassist, or bundled :/ resources): %2")
QStringLiteral(
"%1: path is outside the allowed read roots "
"(the project directory, ~/qodeassist, or bundled :/ resources): %2")
.arg(QString::fromLatin1(fn), path)
.toStdString());
}
@@ -77,6 +84,13 @@ void registerReadFile(inja::Environment &env, const Bindings &b)
const QString path
= expandAndResolvePath(QString::fromStdString(args.at(0)->get<std::string>()), caps);
if (hasUnresolvedVars(path)) {
throw std::runtime_error(QStringLiteral(
"read_file: ${PROJECT_DIR}/${CONFIG_DIR} is not available "
"(no project open?): %1")
.arg(path)
.toStdString());
}
if (!isPathAllowed(path, caps))
throwOutsideRoots("read_file", path);
@@ -97,6 +111,8 @@ void registerFileExists(inja::Environment &env, const Bindings &b)
env.add_callback("file_exists", 1, [caps](inja::Arguments &args) -> nlohmann::json {
const QString p
= expandAndResolvePath(QString::fromStdString(args.at(0)->get<std::string>()), caps);
if (hasUnresolvedVars(p))
return false;
if (!isPathAllowed(p, caps))
throwOutsideRoots("file_exists", p);
return QFileInfo::exists(p);
@@ -110,6 +126,8 @@ void registerReadDir(inja::Environment &env, const Bindings &b)
env.add_callback("read_dir", 1, [caps](inja::Arguments &args) -> nlohmann::json {
const QString p
= expandAndResolvePath(QString::fromStdString(args.at(0)->get<std::string>()), caps);
if (hasUnresolvedVars(p))
return nlohmann::json::array();
if (!isPathAllowed(p, caps))
throwOutsideRoots("read_dir", p);
QDir dir(p);